tests: posix: common: separate posix threads_ext to standalone test #81613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
previously approved these changes
Nov 20, 2024
cfriedt
requested changes
Nov 20, 2024
@cfriedt should the ones that belong to POSIX_THREADS_BASE be moved? |
Probably not until other tests for POSIX_THREADS_BASE are moved. |
Pancakem
force-pushed
the
separate_posix_thread_ext_into_standalone_test
branch
from
8e77f88 to
455971c
Compare
|
@cfriedt I stripped down POSIX_THREADS_EXT to this. Is it faithful to what is needed? |
cfriedt
reviewed
Nov 21, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
cfriedt
requested changes
Nov 21, 2024
Pancakem
force-pushed
the
separate_posix_thread_ext_into_standalone_test
branch
from
455971c to
4e84eb2
Compare
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves pthread_attr into a singular testsuite at tests/posix/threads/ext app directory. Signed-off-by: Marvin Ouma <[email protected]>
Pancakem
force-pushed
the
separate_posix_thread_ext_into_standalone_test
branch
from
4e84eb2 to
4497790
Compare
cfriedt
approved these changes
Dec 3, 2024
cfriedt
approved these changes
Dec 3, 2024
ycsin
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81490
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves pthread_attr into a singular testsuite at tests/posix/threads/ext app directory.