Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: posix: common: separate xsi streams to standalone test #81445

Conversation

Pancakem
Copy link
Contributor

@Pancakem Pancakem commented Nov 15, 2024

Fixes #81492
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves stropts into a singular testsuite at tests/posix/xopen_streams app directory.

@zephyrbot zephyrbot added the area: POSIX POSIX API Library label Nov 15, 2024
@zephyrbot zephyrbot requested review from cfriedt and ycsin November 15, 2024 13:59
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use xsi_streams as the option group name / directory name.

tests/posix/xopen_streams/CMakeLists.txt Outdated Show resolved Hide resolved
@Pancakem Pancakem force-pushed the separate_posix_xopen_streams_to_standalone_test branch from 1287e47 to 26a057d Compare November 16, 2024 06:56
@cfriedt cfriedt changed the title tests: posix: common: separate posix xopen streams to standalone test tests: posix: common: separate xsi streams to standalone test Nov 17, 2024
posix.common contains testsuites that can be separated into smaller
groups of tests. This change moves stropts into a singular
testsuite at tests/posix/xsi_streams app directory.

Signed-off-by: Marvin Ouma <[email protected]>
@Pancakem Pancakem force-pushed the separate_posix_xopen_streams_to_standalone_test branch from 26a057d to 8b714ff Compare November 19, 2024 14:07
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but at some point, we should deprecate CONFIG_XOPEN_STREAMS and call it CONFIG_XSI_STREAMS to match the Option Group.

@nashif nashif merged commit 91749df into zephyrproject-rtos:main Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: posix: common: split xsi_streams tests into standalone test
5 participants