dts: arm: rpi_pico: remove #define from dts

[Siliconsignals]

we can not use #define. Instead, include a dt-bindings header including the definitions.

Fixes: #79719

[nordicjm]

Whilst the move for the defines is fine, how is this fixing the original issue of RPI_PICO_DEFAULT_IRQ_PRIORITY?

[Siliconsignals]

Hi @nordicjm,

Thank you for your input.

This PR addresses just issue #79719 by removing direct #define usage in the DTS file and converting these definitions to use a dt-bindings header instead.

Regarding RPI_PICO_DEFAULT_IRQ_PRIORITY, if you recommend, we could consider adding it to the Kconfig file for the RPI_PICO board. Alternatively, please let me know if you have any other suggestions on how to handle RPI_PICO_DEFAULT_IRQ_PRIORITY.

[nordicjm]

Kconfig cannot be used from dts. Have spoken with Gerard who suggests to use the way it is done with nordic devices, the reset file change can stay but without the IRQ part, use the equivalent override here and define below it with the comment: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/common/nordic/nrf_common.dtsi#L15 add an override file similar to https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/arm/nordic/override.dtsi then all should work

[Siliconsignals]

Kconfig cannot be used from dts. Have spoken with Gerard who suggests to use the way it is done with nordic devices, the reset file change can stay but without the IRQ part,

okay

use the equivalent override here and define below it with the comment: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/common/nordic/nrf_common.dtsi#L15 add an override file similar to https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/arm/nordic/override.dtsi then all should work

sure, will do

[Siliconsignals]

Hi @nordicjm,

Could you please confirm if this change aligns with your requirements? I’d appreciate any feedback to ensure it meets your expectations.

[nordicjm]

Thanks

[nordicjm]

@Tarangraval21 can you check compliance and fix issues?

[Siliconsignals]

@nordicjm,

@Tarangraval21 can you check compliance and fix issues?

ohh okay , The subject line "Update dts/arm/rpi_pico/rp2040.dtsi" is not in the correct format, and the patch is missing the signed-off-by tag.

i will fix it.

[nordicjm]

The merge commit needs to be removed, rebases are used for pulling in latest zephyr changes (which you only need to do if there is a file conflict)

[Siliconsignals]

@nordicjm

I am encountering build failures in the "Run tests with twister / twister-build(2) (pull_request_target)

error log:
INFO    - The following issues were found (showing the top 10 items):
INFO    - 1) samples/psa/its/sample.psa.its.tfm on mps3/corstone300/fvp/ns error (Build failure)
INFO    - 2) samples/psa/persistent_key/sample.psa.persistent_key.tfm on mps3/corstone300/fvp/ns error (Build failure)
INFO    - 3) samples/psa/its/sample.psa.its.tfm on mps3/corstone310/fvp/ns error (Build failure)
INFO    - 4) samples/psa/persistent_key/sample.psa.persistent_key.tfm on mps3/corstone310/fvp/ns error (Build failure)
INFO    - 
INFO    - To rerun the tests, call twister using the following commandline:
INFO    - west twister -p <PLATFORM> -s <TEST ID>, for example:
INFO    - 
INFO    - west twister -p mps3/corstone310/fvp/ns -s samples/psa/persistent_key/sample.psa.persistent_key.tfm
INFO    - or with west:
INFO    - west build -p -b mps3/corstone310/fvp/ns samples/psa/persistent_key -T sample.psa.persistent_key.tfm
INFO    - -+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
INFO    - Run completed

Error: Error: failed to run script step: command terminated with non-zero exit code: Error executing in Docker Container: 1
Error: Process completed with exit code 1.
Error: Executing the custom container implementation failed. Please contact your self hosted runner administrator.

I am unable to determine how these build failures are related to the current patch. Could you please help clarify or provide guidance on troubleshooting these issues?

[nordicjm]

Can you squash these commits? In rebase, mark the second as fixup. Also do a rebase on main and hopefully CI should pass