Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: uart: esp32: Test configuration #81159

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

raffarost
Copy link
Collaborator

Add file configs for ESP32 devices for CI testing.
Get baudrate from device tree for uart_basic_api and uart_elementary tests.
Fix esp32 uart driver function uart_get_config to return standard baudrate value.

@raffarost raffarost force-pushed the tests/uart_loop branch 3 times, most recently from 339219f to a2f11b5 Compare November 9, 2024 02:09
@raffarost raffarost changed the title tests: uart: esp32: Add configs for devices tests: uart: esp32: Test configuration Nov 9, 2024
@rruuaanng rruuaanng added area: UART Universal Asynchronous Receiver-Transmitter area: Tests Issues related to a particular existing or missing test platform: ESP32 Espressif ESP32 labels Nov 9, 2024
@raffarost raffarost marked this pull request as ready for review November 12, 2024 14:02
dcpleung
dcpleung previously approved these changes Nov 12, 2024
wmrsouza
wmrsouza previously approved these changes Nov 12, 2024
sylvioalves
sylvioalves previously approved these changes Nov 12, 2024
marekmatej
marekmatej previously approved these changes Nov 12, 2024
@raffarost raffarost force-pushed the tests/uart_loop branch 2 times, most recently from 845ddf4 to 8824756 Compare November 14, 2024 16:40
sylvioalves
sylvioalves previously approved these changes Nov 14, 2024
wmrsouza
wmrsouza previously approved these changes Nov 14, 2024
Copy link
Member

@dcpleung dcpleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are amending the changes, please leave the whitespace changes out of functional changes. This will make future reviewing (and git log/show) of code easier to understand.

sylvioalves
sylvioalves previously approved these changes Nov 27, 2024
sylvioalves
sylvioalves previously approved these changes Nov 27, 2024
wmrsouza
wmrsouza previously approved these changes Nov 27, 2024
LucasTambor
LucasTambor previously approved these changes Nov 27, 2024
Raffael Rostagno added 3 commits November 28, 2024 14:23
Add option (BAUDRATE_FROM_DTS) to get baudrate value from
device tree, for devices which differ from standard (115200).

Signed-off-by: Raffael Rostagno <[email protected]>
Return standard baudrate on a uart_config_get call instead of
rough calculated numbers.

Signed-off-by: Raffael Rostagno <[email protected]>
Add test configuration for ESP32 devices.

Signed-off-by: Raffael Rostagno <[email protected]>
@raffarost
Copy link
Collaborator Author

@dcpleung @nashif PTAL

@sylvioalves
Copy link
Collaborator

@dcpleung @kartben ping.

@kartben
Copy link
Collaborator

kartben commented Dec 19, 2024

Co-assigning to @sylvioalves as platform owner and due to the nature of the changes.
@dcpleung is on leave but I'm confident his previous NACK has been addressed.

@kartben kartben merged commit f98868e into zephyrproject-rtos:main Dec 19, 2024
26 checks passed
@raffarost raffarost deleted the tests/uart_loop branch December 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants