Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: posix: common: separate posix semaphore tests into a standalone test #80940

Conversation

Pancakem
Copy link
Contributor

@Pancakem Pancakem commented Nov 5, 2024

Fixes #80964

posix.common contains testsuites that can be separated into smaller groups of tests. This change moves semaphore into a singular testsuite at tests/posix/semaphore app directory.

@zephyrbot zephyrbot added the area: POSIX POSIX API Library label Nov 5, 2024
@zephyrbot zephyrbot requested review from cfriedt and ycsin November 5, 2024 17:30
@Pancakem Pancakem force-pushed the origin/separate_posix_semaphores_test_into_standalone_test branch from a0647b8 to 473dbb5 Compare November 5, 2024 17:38
tests/posix/semaphore/prj.conf Outdated Show resolved Hide resolved
tests/posix/semaphore/prj.conf Outdated Show resolved Hide resolved
@Pancakem Pancakem force-pushed the origin/separate_posix_semaphores_test_into_standalone_test branch from 473dbb5 to af1f190 Compare November 6, 2024 11:02
@Pancakem Pancakem force-pushed the origin/separate_posix_semaphores_test_into_standalone_test branch 4 times, most recently from 1b595b3 to 05fd4f7 Compare November 7, 2024 14:39
cfriedt
cfriedt previously approved these changes Nov 7, 2024
@cfriedt
Copy link
Member

cfriedt commented Nov 7, 2024

@Pancakem - please apply this diff

diff --git a/tests/posix/semaphores/testcase.yaml b/tests/posix/semaphores/testcase.yaml
index 2ad9053724c..92fdebbd992 100644
--- a/tests/posix/semaphores/testcase.yaml
+++ b/tests/posix/semaphores/testcase.yaml
@@ -7,10 +7,10 @@ common:
   platform_key:
     - arch
     - simulation
+  min_flash: 64
+  min_ram: 32
 tests:
-  portability.posix.semaphores:
-    min_flash: 64
-    min_ram: 32
+  portability.posix.semaphores: {}
   portability.posix.semaphores.minimal:
     extra_configs:
       - CONFIG_MINIMAL_LIBC=y

… test

posix.common contains testsuites that can be separated into smaller
groups of tests. This change moves semaphore into a singular
testsuite at tests/posix/semaphores app directory.

Signed-off-by: Marvin Ouma <[email protected]>
@Pancakem Pancakem force-pushed the origin/separate_posix_semaphores_test_into_standalone_test branch from 05fd4f7 to 357b5e4 Compare November 12, 2024 08:43
@nashif nashif merged commit f7633a5 into zephyrproject-rtos:main Nov 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: posix: common: split semaphore tests into a standalone test
5 participants