drivers: eeprom: at2x: streamline codebase #80660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To maintain consistency in `init_fn` parameter passing,
remove the address-of operator ('&') when assigning the `init_fn`
function pointer in the `DEVICE_DT_INST_DEFINE` macro.
Signed-off-by: Pisit Sawangvonganan <[email protected]>
Remove orphaned `k_mutex_unlock` in `eeprom_at25_read` as the lock/unlock pair is handled in `eeprom_at2x_read` instead. Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
force-pushed
the
pr_drivers_eeprom_at2x_refactor
branch
from
35ca62b to
4c68fd3
Compare
henrikbrixandersen
requested changes
Nov 1, 2024
drivers/eeprom/eeprom_at2x.c
Outdated
| const struct spi_buf tx_buf = { | ||
| .buf = &cmd, | ||
| static const uint8_t cmd = EEPROM_AT25_WREN; | ||
| static const struct spi_buf tx_buf = { |
There was a problem hiding this comment.
Not sure the static const changes are okay. Some SPI-controller drivers may be using DMA yet unable to DMA transfer from flash. I'd prefer to leave these as-is.
|
@ndrs-pst Any plans for picking up this PR and addressing the requested change? |
|
That means, even if it uses synchronous APIs and does not involve DMA transfers, it would not be justified. |
ndrs-pst
force-pushed
the
pr_drivers_eeprom_at2x_refactor
branch
from
4c68fd3 to
ed9048c
Compare
henrikbrixandersen
approved these changes
Dec 19, 2024
fabiobaltieri
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 changes to the
eeprom_at2x.cfile as follows:init_fninDEVICE_DT_INST_DEFINEmacrok_mutex_unlockineeprom_at25_read