tests: boards: nrf: qdec: Fix failing drivers.sensor.qdec.pm_runtime #80051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was failing because after re-enabling QDEC there is an interrupt REPORTRDY coming after some time. Test had k_msleep(100) added to accomodate for that but it was added after sensor_sample_fetch and should be added before so that sample with data from REPORTRDY event is fetched so that next read is empty as expected. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
requested review from
nordic-piks,
anangl,
bjarki-andreasen,
gmarull and
masz-nordic
nordic-piks
approved these changes
Oct 18, 2024
mstasiaknordic
approved these changes
Oct 18, 2024
gmarull
approved these changes
Oct 18, 2024
anangl
approved these changes
Oct 18, 2024
bjarki-andreasen
approved these changes
Oct 18, 2024
nordic-krch
added a commit
to nordic-krch/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 22, 2024
…dec.pm_runtime Test was failing because after re-enabling QDEC there is an interrupt REPORTRDY coming after some time. Test had k_msleep(100) added to accomodate for that but it was added after sensor_sample_fetch and should be added before so that sample with data from REPORTRDY event is fetched so that next read is empty as expected. Upstream PR: zephyrproject-rtos/zephyr#80051 Signed-off-by: Krzysztof Chruściński <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…dec.pm_runtime Test was failing because after re-enabling QDEC there is an interrupt REPORTRDY coming after some time. Test had k_msleep(100) added to accomodate for that but it was added after sensor_sample_fetch and should be added before so that sample with data from REPORTRDY event is fetched so that next read is empty as expected. Upstream PR: zephyrproject-rtos/zephyr#80051 Signed-off-by: Krzysztof Chruściński <[email protected]>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…dec.pm_runtime Test was failing because after re-enabling QDEC there is an interrupt REPORTRDY coming after some time. Test had k_msleep(100) added to accomodate for that but it was added after sensor_sample_fetch and should be added before so that sample with data from REPORTRDY event is fetched so that next read is empty as expected. Upstream PR: zephyrproject-rtos/zephyr#80051 Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 8ceab93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was failing because after re-enabling QDEC there is an interrupt REPORTRDY coming after some time. Test had k_msleep(100) added to accomodate for that but it was added after sensor_sample_fetch and should be added before so that sample with data from REPORTRDY event is fetched so that next read is empty as expected.
Fixes #80050.