nRF7002 shields: fix COEX interface #79606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Wi-Fi
zephyrbot
requested review from
avisconti,
erwango,
jaz1-nordic,
jfischer-no,
jukkar,
kartben,
kl-cruz,
Kludentwo,
krish2718,
magp-nordic,
masz-nordic,
nika-nordic,
rlubos and
sachinthegreen
bjarki-andreasen
force-pushed
the
nrf7002-shields-align-coex
branch
from
88bc6f8 to
5503889
Compare
|
krish2718
previously approved these changes
Oct 10, 2024
jukkar
previously approved these changes
Oct 11, 2024
The nrf7000, nrf7001 and nrf7002 expose a coex hardware interface which is independent from the wifi/control interface (spi and control pins) These interfaces where previously combined into a single model. This is incompatible with the actual usage of the interfaces where one core may interact only with the coex interface, and another with the wifi/control interface. This commit moves the coex interface, commonly described in "nordic,nrf70-coex.yaml", out of the wifi/control models "nrf700<variant>-<bus>.yaml" to its own models "nrf700<variant>-coex.yaml" Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Remove the unused coex interface from the cpuapp of the nrf7002dk nrf5340 SoC. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Exclude the coex interface if the coex variant of the nrf7002eb is selected instead of adding the interface alongside the wifi/control interface. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
dismissed stale reviews from jukkar and krish2718
via
9f8790d
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
…nterface Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The nrf7000, nrf7001 and nrf7002 expose a coex hardware interface which is independent from the wifi/control interface (spi and control pins) These interfaces where previously combined into a single model. This is incompatible with the actual usage of the interfaces where one core may interact only with the coex interface, and another with the wifi/control interface. This commit moves the coex interface, commonly described in "nordic,nrf70-coex.yaml", out of the wifi/control models "nrf700<variant>-<bus>.yaml" to its own models "nrf700<variant>-coex.yaml" Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…terface Remove the unused coex interface from the cpuapp of the nrf7002dk nrf5340 SoC. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Exclude the coex interface if the coex variant of the nrf7002eb is selected instead of adding the interface alongside the wifi/control interface. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The nrf7000, nrf7001 and nrf7002 expose a coex hardware interface which is independent from the wifi/control interface (spi and control pins) These interfaces where previously combined into a single model. This is incompatible with the actual usage of the interfaces where one core may interact only with the coex interface, and another with the wifi/control interface. This commit moves the coex interface, commonly described in "nordic,nrf70-coex.yaml", out of the wifi/control models "nrf700<variant>-<bus>.yaml" to its own models "nrf700<variant>-coex.yaml" Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…terface Remove the unused coex interface from the cpuapp of the nrf7002dk nrf5340 SoC. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Exclude the coex interface if the coex variant of the nrf7002eb is selected instead of adding the interface alongside the wifi/control interface. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The nrf7000, nrf7001 and nrf7002 expose a coex hardware interface which is independent from the wifi/control interface (spi and control pins) These interfaces where previously combined into a single model. This is incompatible with the actual usage of the interfaces where one core may interact only with the coex interface, and another with the wifi/control interface. This commit moves the coex interface, commonly described in "nordic,nrf70-coex.yaml", out of the wifi/control models "nrf700<variant>-<bus>.yaml" to its own models "nrf700<variant>-coex.yaml" Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit ec25606)
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…terface Remove the unused coex interface from the cpuapp of the nrf7002dk nrf5340 SoC. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 1492f1d)
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Exclude the coex interface if the coex variant of the nrf7002eb is selected instead of adding the interface alongside the wifi/control interface. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 32f30a8)
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 6b38f1a)
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 9236bc2)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The nrf7000, nrf7001 and nrf7002 expose a coex hardware interface which is independent from the wifi/control interface (spi and control pins) These interfaces where previously combined into a single model. This is incompatible with the actual usage of the interfaces where one core may interact only with the coex interface, and another with the wifi/control interface. This commit moves the coex interface, commonly described in "nordic,nrf70-coex.yaml", out of the wifi/control models "nrf700<variant>-<bus>.yaml" to its own models "nrf700<variant>-coex.yaml" Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit ec25606)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…terface Remove the unused coex interface from the cpuapp of the nrf7002dk nrf5340 SoC. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 1492f1d)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Exclude the coex interface if the coex variant of the nrf7002eb is selected instead of adding the interface alongside the wifi/control interface. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 32f30a8)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…nterface Add variant for the coex interface and move the coex interface out if the wifi/control interface variants. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 6b38f1a)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 9236bc2)
anangl
approved these changes
Oct 28, 2024
bjarki-andreasen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move out the independent COEX interface from the wifi/control interface of the
nrf700xseries of chips.The COEX interface is used independently by cores like nrf5340/cpunet, which don't/can't use the the SPI/QSPI based wifi/control interface. Without this fix, this is not possible.
This PR splits the interface into its own binding, which represents the hardware model of the COEX interface. Thus, the COEX interface can be used as designed.