drivers: gpio: xlnx_ps: switch driver over to DEVICE_MMIO mapping #78255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
requested changes
Sep 12, 2024
ibirnbaum
force-pushed
the
ps7_gpio_device_mmio
branch
from
7425bb0 to
e60678d
Compare
henrikbrixandersen
previously approved these changes
Sep 23, 2024
Set up a named device MMIO memory mapping in the GPIO controller's parent device, map the virtual memory in the init function of the parent device. Once the controller's register space has been successfully mapped, propagate the mapped virtual address to all child (= GPIO bank) devices. While it is possible to add a named mapping to every single GPIO bank device and initialize it in the respective bank device's init function, this would result in multiple virtual address mappings all pointing to the same 4k of physical memory. I assume that, although all those mappings having the same attri- butes, such a setup is at least discouraged. Signed-off-by: Immo Birnbaum <[email protected]>
Remove the PS GPIO controller's static MMU region entry from the mmu_regions table for both the XC7Zxxx and XC7ZxxxS variants of the Zynq 7000. The PS GPIO controller's device driver has been switched over to using a named DEVICE_MMIO mapping. Signed-off-by: Immo Birnbaum <[email protected]>
ibirnbaum
force-pushed
the
ps7_gpio_device_mmio
branch
from
e60678d to
7c17870
Compare
|
Re-based due to the adoption of #82180. |
henrikbrixandersen
approved these changes
Dec 16, 2024
kartben
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up a named device MMIO memory mapping in the GPIO controller's parent device, map the virtual memory in the init function of the parent device.
Once the controller's register space has been successfully mapped, propagate the mapped virtual address to all child (= GPIO bank) devices. While it is possible to add a named mapping to every single GPIO bank device and initialize it in the respective bank device's init function, this would result in multiple virtual address mappings all pointing to the same 4k of physical memory. I assume that, although all those mappings having the same attributes, such a setup is at least discouraged.