tests: drivers: adc_accuracy #76088
Merged
tests: drivers: adc_accuracy #76088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-babu
force-pushed
the
extend-adc-ref
branch
2 times, most recently
from
f5f00d8 to
ab32d06
Compare
nordic-bami
approved these changes
Jul 19, 2024
nordic-segl
approved these changes
Jul 19, 2024
nordic-piks
approved these changes
Jul 19, 2024
nordic-babu
force-pushed
the
extend-adc-ref
branch
from
d25a8a5 to
e97c91e
Compare
bjarki-andreasen
previously approved these changes
Jul 19, 2024
decsny
previously approved these changes
Jul 19, 2024
bjarki-andreasen
previously approved these changes
Jul 20, 2024
nordic-babu
added a commit
to nordic-babu/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf52840dk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
added a commit
to nordic-babu/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf54h20dk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
added a commit
to nordic-babu/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf54l15pdk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
added a commit
to nordic-babu/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
…r nrf54. It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf52840dk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf54h20dk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
Add overlay and enable test for nrf54l15pdk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 23, 2024
…r nrf54. It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
dismissed stale reviews from bjarki-andreasen and decsny
via
a2ced2f
|
had to parametrize expected accuracy, need other value for some nrf boards to pass on our internal setups |
nordic-piks
approved these changes
Jul 23, 2024
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Add overlay and enable test for nrf54h20dk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 9cfc59e)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Add overlay and enable test for nrf54l15pdk. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 5ca3d32)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…r nrf54. It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 8b6e30f)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…uracy On nrf boards expected accuracy from ref voltage is 64 instead of 32. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 3107c7a)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
sampling Calibrate adc before taking measurement. Upstream PR: zephyrproject-rtos/zephyr#76088 Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 0e4d6d5)
|
@nordic-babu please rebase |
Add overlay and enable test for nrf52840dk. Signed-off-by: Bartlomiej Buczek <[email protected]>
Add overlay and enable test for nrf54h20dk. Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
force-pushed
the
extend-adc-ref
branch
2 times, most recently
from
58e7e51 to
3eaa712
Compare
anangl
requested changes
Oct 22, 2024
| @@ -21,5 +21,5 @@ tests: | |||
| - ek_ra8m1 | |||
| - frdm_mcxc242 | |||
| - nrf52840dk/nrf52840 | |||
| - nrf54l15pdk/nrf54l15/cpuapp | |||
| - nrf54l15dk/nrf54l15/cpuapp | |||
There was a problem hiding this comment.
Wrong commit, This should be corrected in tests: adc_accuracy: add overlay for nrf54l15dk..
There was a problem hiding this comment.
change moved to correct commit
Add overlay and enable test for nrf54l15dk. Signed-off-by: Bartlomiej Buczek <[email protected]>
It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
force-pushed
the
extend-adc-ref
branch
from
3eaa712 to
ce15968
Compare
anangl
previously approved these changes
Oct 22, 2024
carlescufi
previously approved these changes
Oct 22, 2024
On nrf boards expected accuracy from ref voltage is 64 instead of 32. Signed-off-by: Bartlomiej Buczek <[email protected]>
Calibrate adc before taking measurement. Signed-off-by: Bartlomiej Buczek <[email protected]>
nordic-babu
force-pushed
the
extend-adc-ref
branch
from
ce15968 to
797310d
Compare
|
Aligned some boards overlays to fix CI |
nordic-segl
approved these changes
Oct 23, 2024
anangl
approved these changes
Oct 23, 2024
carlescufi
approved these changes
Oct 23, 2024
57300
pushed a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…r nrf54. Upstream PR: zephyrproject-rtos/zephyr#76088 It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 71ae6ff6f10497e816fcf2da05ee0887dd5452df)
57300
pushed a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…r nrf54. Upstream PR: zephyrproject-rtos/zephyr#76088 It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 71ae6ff6f10497e816fcf2da05ee0887dd5452df)
57300
pushed a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…r nrf54. Upstream PR: zephyrproject-rtos/zephyr#76088 It will increase test coverage for adc driver, no test uses ADC_GAIN_2_3 setting yet. Signed-off-by: Bartlomiej Buczek <[email protected]> (cherry picked from commit 71ae6ff6f10497e816fcf2da05ee0887dd5452df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overlays and enable test for nrf52840dk/nrf54h20dk/nrf54l15dk.