posix: add stubs for signal.h functions that need process support #74436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
posix-signals-stubs
branch
2 times, most recently
from
a38404d to
2baac4a
Compare
cfriedt
added
area: POSIX
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
2baac4a to
37370cf
Compare
ceolin
previously approved these changes
Jun 17, 2024
| char *strsignal(int signum); | ||
| int sigemptyset(sigset_t *set); | ||
| int sigfillset(sigset_t *set); | ||
| int sigaddset(sigset_t *set, int signo); | ||
| int sigdelset(sigset_t *set, int signo); | ||
| int sigismember(const sigset_t *set, int signo); | ||
| void (*signal(int signo, void (*)(int signo)))(int signo); |
There was a problem hiding this comment.
GNU extension is so much clear :)
typedef void (*sighandler_t)(int);
sighandler_t signal(int signum, sighandler_t handler);
There was a problem hiding this comment.
It is convenient, but also a gnu-ism.
There was a problem hiding this comment.
I haven't seen any conflicts when using the typedef, even when building using native_sim, so I'll add it as well.
| sigset_t sa_mask; | ||
| int sa_flags; | ||
| void (*sa_sigaction)(int signo, siginfo_t *info, void *context); | ||
| }; |
There was a problem hiding this comment.
Shouldn't it be
struct sigaction {
void (*sa_handler)(int signno);
void (*sa_sigaction)(int signo, siginfo_t *info, void *context);
sigset_t sa_mask;
int sa_flags;
};
to avoid possible hole in the struct.
zephyrbot
requested review from
aescolar,
keith-packard,
nashif,
stephanosio and
ycsin
ycsin
previously approved these changes
Jun 18, 2024
|
Adding a temporary DNM until all comments have been addressed. |
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
37370cf to
2fe2dcd
Compare
|
ycsin
previously approved these changes
Jun 26, 2024
added 3 commits
June 27, 2024 11:45
Newlib requires an alias for the getpid() function. There was a Kconfig already present for doing so, but the actual alias was missing. So this is technically a bugfix. Signed-off-by: Chris Friedt <[email protected]>
Since Zephyr itself does not currently support processes, but conformant applications should still be able to link, add stubs for the remaining POSIX functions in the POSIX_SIGNALS Option Group. The POSIX_SIGNALS Option Group is required for PSE51, PSE52, PSE53, PSE54, and likely many other POSIX Subprofiles. Signed-off-by: Chris Friedt <[email protected]>
Add tests for the presence of items in the POSIX SIGNALS Option Group. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
2fe2dcd to
e511bdd
Compare
Please add a refresh +1 @ycsin @vaishnavachath |
Mark the POSIX_SIGNALS Option Group as supported to the extent possible under Zephyr, as Zephyr does not yet support processes. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
posix-signals-stubs
branch
from
e511bdd to
4bd5b2c
Compare
ceolin
approved these changes
Jun 27, 2024
nashif
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Zephyr itself does not currently support processes, but conformant applications should still be able to link, add stubs for the remaining POSIX functions in the
POSIX_SIGNALSOption Group.The
POSIX_SIGNALSOption Group is required for PSE51, PSE52, PSE53, PSE54, and likely many other POSIX Subprofiles.Note
There is a Coding Guidelines false positive about declaring the
raise()function (from C89).Doc Preview
Fixes #59925
Fixes #59933
Fixes #66923
Fixes #66924
Fixes #66925
Fixes #66929
Fixes #66930