-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Convert HCI drivers to use a proper Zephyr driver API #72323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedberg
commented
May 5, 2024
jhedberg
force-pushed
the
bt_hci_driver
branch
2 times, most recently
from
May 5, 2024 16:06
7bebbc5
to
a841b2a
Compare
jhedberg
commented
May 5, 2024
jhedberg
force-pushed
the
bt_hci_driver
branch
4 times, most recently
from
May 6, 2024 08:56
4f65c0e
to
94a0e38
Compare
jhedberg
force-pushed
the
bt_hci_driver
branch
10 times, most recently
from
May 13, 2024 10:08
cb2bbdb
to
a963844
Compare
jhedberg
force-pushed
the
bt_hci_driver
branch
2 times, most recently
from
May 13, 2024 13:22
0ae93c5
to
54bde20
Compare
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625)
jukkar
pushed a commit
to jukkar/sdk-zephyr
that referenced
this pull request
Dec 5, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 25e8625) (cherry picked from commit 8b26afd)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Dec 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Dec 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Dec 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Dec 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Dec 30, 2024
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 3, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 3, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 7, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 8, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 8, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 8, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 8, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 10, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jan 10, 2025
The nRF54H20 supports a Bluetooth controller. The HCI driver interface has changed upstream in zephyrproject-rtos/zephyr#72323 so now we need to add it to device tree. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit f47a9b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status:
h4.c
samples/bluetooth/hci_uart_async/
to work with the new driver modelbt_read_static_addr()
. Taken care of by Bluetooth: Simplify Kconfig options and interface between the host and controller #72580BT_HAS_HCI_VS
,BT_HCI_VS
andBT_HCI_VS_EXT
(perhaps DTS properties?). Some preparation in Bluetooth: Simplify Kconfig options and interface between the host and controller #72580.unit_testing
"board" right now: Bluetooth: controller: Add BT_CTLR_HCI Kconfig option #72871ipc.c
userchan.c
h5.c
hci_ambiq.c
(and associated DT binding)hci_b91.c
: Bluetooth: drivers: Remove unmaintained B91 HCI driver #73289hci_esp32.c
hci_psoc6_bless.c
(and associated DT binding)hci_spi_st.c
(and associated DT binding)hci_stm32wba.c
ipm_stm32wb.c
(and associated DT binding)spi.c
hci_da1469x.c
hci_nxp.c
slz_hci.c
/chosen
propertiesnrf52_bsim
to use also UART for HCIsamples/
andtests/
that use the legacy HCI driver APIchoice
section for HCI driversBT_NO_DRIVER
Right now the host
hci_core.c
uses#if DT_HAS_CHOSEN(zephyr_bt_hci)
to separate the new-style HCI drivers from the legacy HCI driver support. The old API has been deprecated, but will only be removed after a deprecation period.The following drivers depend on "west blobs", so they're not covered by CI, but were manually compile tested:
hci_psoc6_bless.c
(west blobs fetch hal_infineon
)hci_esp32.c
(west blobs fetch hal_espressif
)hci_stm32wba.c
(west blobs fetch hal_stm32
doesn't work for me, see Bluetooth: Convert HCI drivers to use a proper Zephyr driver API #72323 (comment) )slz_hci.c
(west blobs fetch hal_silabs
, same problem for me as with stm32, i.e. had to manually download)What this PR doesn't try to tackle:
zephyr/drivers/bluetooth/hci/apollox_blue.c
Lines 289 to 333 in d3c0dfb
BT_HCI_ACL_FLOW_CONTROL
currently referencing specific HCI driversrecv
callback to the host, rather there needs to be another mechanism for the host to fetch data from the driver.Fixes #51503