Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifi: shell: Support multiple security modes for each network #71044

Merged
merged 1 commit into from
Apr 19, 2024
Merged

wifi: shell: Support multiple security modes for each network #71044

merged 1 commit into from
Apr 19, 2024

Conversation

rado17
Copy link
Contributor

@rado17 rado17 commented Apr 3, 2024

Support configuration of multiple security modes for each network.

@zephyrbot zephyrbot requested review from jukkar, krish2718 and rlubos April 3, 2024 11:54
@rado17
Copy link
Contributor Author

rado17 commented Apr 3, 2024

@sachinthegreen @VivekUppunda @kapbh @ajayparida Please check

@rado17 rado17 force-pushed the multi_sec_config branch from 0b29baa to b7449a2 Compare April 3, 2024 11:59
ajayparida
ajayparida reviewed Apr 3, 2024
View reviewed changes
subsys/net/l2/wifi/wifi_shell.c Outdated Show resolved Hide resolved
subsys/net/l2/wifi/wifi_shell.c Outdated Show resolved Hide resolved
krish2718
krish2718 requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested iadding a WPA_AUTO_PERSONAL would be enough and we can let the drivers/NMs implement this feature.

@rado17 rado17 force-pushed the multi_sec_config branch from b7449a2 to 4bde1bd Compare April 16, 2024 16:27
@rado17 rado17 mentioned this pull request Apr 16, 2024
Merged
@rado17 rado17 force-pushed the multi_sec_config branch 2 times, most recently from b3f286f to fff520f Compare April 16, 2024 19:14
krish2718
krish2718 requested changes Apr 16, 2024
View reviewed changes
subsys/net/l2/wifi/wifi_mgmt.c Outdated Show resolved Hide resolved
@rado17 rado17 force-pushed the multi_sec_config branch from fff520f to 4bc2c58 Compare April 17, 2024 07:56
krish2718
krish2718 previously approved these changes Apr 17, 2024
View reviewed changes
@rado17 rado17 force-pushed the multi_sec_config branch from 4bc2c58 to 1bfed71 Compare April 17, 2024 11:58
jukkar
jukkar previously approved these changes Apr 17, 2024
View reviewed changes
rlubos
rlubos previously approved these changes Apr 17, 2024
View reviewed changes
rado17 added a commit to rado17/sdk-zephyr that referenced this pull request Apr 18, 2024
@rado17
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
ea6bdfc 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17
wifi: shell: Support WPA auto personal security mode
e9375df 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 rado17 dismissed stale reviews from rlubos and jukkar via e9375df April 18, 2024 15:19
@rado17 rado17 force-pushed the multi_sec_config branch from 1bfed71 to e9375df Compare April 18, 2024 15:19
cvinayak pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Apr 19, 2024
@rado17 @cvinayak
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
f46813e 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
gmarull pushed a commit to gmarull/sdk-zephyr that referenced this pull request Apr 19, 2024
@rado17 @gmarull
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
00c1976 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
(cherry picked from commit e9375df78af4ce0589ed8651a500c5d45617fdf2)
rado17 added a commit to rado17/sdk-zephyr that referenced this pull request Apr 19, 2024
@rado17
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
1063d64 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
@fabiobaltieri fabiobaltieri merged commit b45ff98 into zephyrproject-rtos:main Apr 19, 2024
22 checks passed
cvinayak pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Apr 21, 2024
@rado17 @cvinayak
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
2bc4d2c 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
gmarull pushed a commit to gmarull/sdk-zephyr that referenced this pull request Apr 24, 2024
@rado17 @gmarull
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
35629f5 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
(cherry picked from commit e9375df78af4ce0589ed8651a500c5d45617fdf2)
gmarull pushed a commit to gmarull/sdk-zephyr that referenced this pull request Apr 30, 2024
@rado17 @gmarull
[nrf fromlist] wifi: shell: Support WPA auto personal security mode
d39eff8 
Applications need to run a scan to identify the security
mode before attempting the connection which adds to the time
taken for connection to be established.
To avoid the initial scan, support auto security mode which will
enable STA to choose between WPA, WPA2 and WPA3, based on the
network configuration.

Upstream PR: zephyrproject-rtos/zephyr#71044

Signed-off-by: Ravi Dondaputi <[email protected]>
(cherry picked from commit e9375df78af4ce0589ed8651a500c5d45617fdf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VivekUppunda VivekUppunda VivekUppunda approved these changes

@rlubos rlubos rlubos approved these changes

@jukkar jukkar jukkar approved these changes

@krish2718 krish2718 Awaiting requested review from krish2718

@ajayparida ajayparida Awaiting requested review from ajayparida

Assignees

@jukkar jukkar

Labels
area: Networking area: Wi-Fi Wi-Fi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rado17 @jukkar @rlubos @krish2718 @ajayparida @VivekUppunda @fabiobaltieri @zephyrbot