modules: hal_nordic: Add RRAM to NRFX_NVMC #69913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing dependency on nodric,rram-controller compatible. Signed-off-by: Dominik Ermel <[email protected]>
zephyrbot
added
Trivial
de-nordic
added a commit
to de-nordic/sdk-zephyr
that referenced
this pull request
Mar 7, 2024
Add missing dependency on nodric,rram-controller compatible. Upstream PR: zephyrproject-rtos/zephyr#69913 Signed-off-by: Dominik Ermel <[email protected]>
anangl
requested changes
Mar 7, 2024
| @@ -144,6 +144,7 @@ config NRFX_NVMC | |||
| depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF51_FLASH_CONTROLLER)) \ | |||
| || $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF52_FLASH_CONTROLLER)) \ | |||
| || $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF53_FLASH_CONTROLLER)) \ | |||
| || $(dt_has_compat,$(DT_COMPAT_NORDIC_RRAM_CONTROLLER)) \ | |||
There was a problem hiding this comment.
I believe this is wrong. Devices with the RRAM controller should use the RRAMC driver (nrfx_rramc.c), not the NVMC one (nrfx_nvmc.c), so a new option for that driver should be added instead. Or am I missing something?
There was a problem hiding this comment.
AFIK settings of this option adds nrf_nvmc.c nrfx driver to the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing dependency on nodric,rram-controller compatible.