modem: cmux: fix frame data length encoding #67062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the data is bigger than 127 bytes, the first bit of the second byte of the data length field used to always be set. This is wrong as according to the 3GPP 27.010 spec only the first bit of the first byte is the EA bit; all the others denote the data length. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
force-pushed
the
modem_cmux_fix
branch
from
7fb47be to
a72fb73
Compare
zephyrbot
added
the
Trivial
fabiobaltieri
approved these changes
Dec 29, 2023
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Jan 2, 2024
This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]>
fabiobaltieri
pushed a commit
that referenced
this pull request
Jan 11, 2024
This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in #67062. Signed-off-by: Pisit Sawangvonganan <[email protected]>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Jan 12, 2024
This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. (cherry picked from commit 1270bce) Original-Signed-off-by: Pisit Sawangvonganan <[email protected]> GitOrigin-RevId: 1270bce Change-Id: I25641650274c52a84e8c9c3866d5712bb037b318 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5192492 Reviewed-by: Tristan Honscheid <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]> Commit-Queue: Tristan Honscheid <[email protected]> Tested-by: Tristan Honscheid <[email protected]>
mpenate-ellenbytech
pushed a commit
to mpenate-ellenbytech/sdk-zephyr
that referenced
this pull request
Jan 31, 2024
This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]>
tomi-font
pushed a commit
to tomi-font/ncs-zephyr
that referenced
this pull request
Feb 16, 2024
…to save ROM This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]> (cherry picked from commit 1270bce)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Feb 19, 2024
…to save ROM This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]> (cherry picked from commit 1270bce)
jfischer-no
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Mar 8, 2024
…to save ROM This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]> (cherry picked from commit 1270bce) (cherry picked from commit 97a72e7)
ldenefle
pushed a commit
to converge-io/sdk-zephyr
that referenced
this pull request
Jun 20, 2024
This optimization aggregates frame headers before adding to the ring buffer and computes the FCS of the frame header in one operation. This approach improves execution efficiency and reduces memory footprint. This code adjustment aligns with the changes proposed in zephyrproject-rtos/zephyr#67062. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the data is bigger than 127 bytes, the first bit of the second byte of the data length field used to always be set.
This is wrong as according to the 3GPP 27.010 spec only the first bit of the first byte is the EA bit; all the others denote the data length.