samples: net: echo_server/client: Decrease SRAM usage for atsamr21_xpro #65781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandojve
added
the
Trivial
zephyrbot
added
area: Samples
zephyrbot
requested review from
jukkar,
kartben,
nashif,
rlubos,
ssharks and
tbursztyka
jukkar
previously approved these changes
Nov 26, 2023
| CONFIG_LOG_MODE_MINIMAL=y | ||
| CONFIG_NET_IP_DSCP_ECN=n | ||
| CONFIG_NET_STATISTICS=n | ||
| CONFIG_NET_MGMT_EVENT_STACK_SIZE=384 |
There was a problem hiding this comment.
This looks too very low, but might work ok. Note that there is CONFIG_NET_DEBUG_MGMT_EVENT_STACK option which prints stack usage after each event, and that can be used to verify the numbers.
There was a problem hiding this comment.
This board have been on limit since 2.7 and I'm constantly reducing something. Besides that still running : )
*** Booting Zephyr OS build zephyr-v3.5.0-5222-g03772eb0d806 ***
uart:~$ I: Initializing network
I: IPv6 address: 2001:db8::1
I: Run echo server
I: Network connected
I: Starting...
I: Waiting for UDP packets on port 4242 (IPv6)...
D: (udp6): UDP (IPv6): Received and replied with 21 bytes
D: (udp6): UDP (IPv6): Received and replied with 46 bytes
D: (udp6): UDP (IPv6): Received and replied with 12 bytes
D: (udp6): UDP (IPv6): Received and replied with 54 bytes
D: (udp6): UDP (IPv6): Received and replied with 84 bytes
D: (udp6): UDP (IPv6): Received and replied with 46 bytes
D: (udp6): UDP (IPv6): Received and replied with 65 bytes
D: (udp6): UDP (IPv6): Received and replied with 3 bytes
D: (udp6): UDP (IPv6): Received and replied with 116 bytes
D: (udp6): UDP (IPv6): Received and replied with 24 bytes
D: (udp6): UDP (IPv6): Received and replied with 95 bytes
D: (udp6): UDP (IPv6): Received and replied with 25 bytes
D: (udp6): UDP (IPv6): Received and replied with 67 bytes
D: (udp6): UDP (IPv6): Received and replied with 97 bytes
D: (udp6): UDP (IPv6): Received and replied with 108 bytes
*** Booting Zephyr OS build zephyr-v3.5.0-5222-g03772eb0d806 ***
uart:~$ I: Initializing network
I: IPv6 address: 2001:db8::2
I: Run echo client
I: Network connected
I: Starting...
D: IPv6 UDP: Sent 21 bytes
D: IPv6 UDP: Received and compared 21 bytes, all ok
D: IPv6 UDP: Sent 46 bytes
D: IPv6 UDP: Received and compared 46 bytes, all ok
D: IPv6 UDP: Sent 12 bytes
D: IPv6 UDP: Received and compared 12 bytes, all ok
D: IPv6 UDP: Sent 54 bytes
D: IPv6 UDP: Received and compared 54 bytes, all ok
D: IPv6 UDP: Sent 84 bytes
D: IPv6 UDP: Received and compared 84 bytes, all ok
D: IPv6 UDP: Sent 46 bytes
D: IPv6 UDP: Received and compared 46 bytes, all ok
D: IPv6 UDP: Sent 65 bytes
D: IPv6 UDP: Received and compared 65 bytes, all ok
D: IPv6 UDP: Sent 3 bytes
D: IPv6 UDP: Received and compared 3 bytes, all ok
D: IPv6 UDP: Sent 116 bytes
D: IPv6 UDP: Received and compared 116 bytes, all ok
D: IPv6 UDP: Sent 24 bytes
D: IPv6 UDP: Received and compared 24 bytes, all ok
D: IPv6 UDP: Sent 95 bytes
D: IPv6 UDP: Received and compared 95 bytes, all ok
D: IPv6 UDP: Sent 25 bytes
D: IPv6 UDP: Received and compared 25 bytes, all ok
D: IPv6 UDP: Sent 67 bytes
D: IPv6 UDP: Received and compared 67 bytes, all ok
D: IPv6 UDP: Sent 97 bytes
D: IPv6 UDP: Received and compared 97 bytes, all ok
D: IPv6 UDP: Sent 108 bytes
D: IPv6 UDP: Received and compared 108 bytes, all ok
MrKevinWeiss
reviewed
Dec 4, 2023
|
@nandojve will you return to this before the 3.6 merge window closes this week? |
|
Yes, thank you! |
|
It would be nice to have in from my side :) |
In the Zephyr v3.5 to build the net samples pair echo-server/client the SRAM requirements increased for the atsamr21_xpro board when passing -DEXTRA_CONF_FILE=overlay-802154.conf argument. This adjusts example features to free necessary SRAM to build and run the example. Signed-off-by: Gerson Fernando Budke <[email protected]>
This update the echo_client configurations for the atsamr21_xpro board to match same configs defined at echo_server. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
samr21/fix_net_socket_example_build_by_the_5_time
branch
from
eb161a9 to
66cdbec
Compare
|
Hi @MaureenHelm , This seems to be ready from my side. I address all comments in regards to best values and made a test on HW yesterday. So, it only depends on approvals. Thank you again to bring this to my attention : ) |
rlubos
approved these changes
Feb 2, 2024
jukkar
approved these changes
Feb 2, 2024
nandojve
deleted the
samr21/fix_net_socket_example_build_by_the_5_time
branch
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Zephyr v3.5 to build the net samples pair echo-server/client the SRAM requirements increased for the atsamr21_xpro board when passing -DEXTRA_CONF_FILE=overlay-802154.conf argument. This adjusts the examples features to free the necessary SRAM to build and run the examples.