[Backport v3.5-branch] scripts: check_init_priorities: usability updates #64772
Conversation
Since bb590b5 introduced ordinals in the priority sequence, the "same priority" case cannot happen anymore, furthermore the priority value in the script is now the position of the function in the init sequence, so if two devices have the same priority there's something real bad going on. Drop all the "same priority" handling code and tests, convert the case into ane exception instead. Drop the init stubs as well from the test, they are not required anymore. Signed-off-by: Fabio Baltieri <[email protected]> (cherry picked from commit 2a70c31)
The current error messages are a bit cryptic, rework them to make them more meaningful: - add an extra message on the first error to explain what the errors refer to. - rework the error message to be more explicit. - rework the priority string print to use a LEVEL+offset format to somehow highlight that the number is the offset from the level, not the actual priority. - print the init function name in addition to the devicetree path. Signed-off-by: Fabio Baltieri <[email protected]> (cherry picked from commit dd178ce)
zephyrbot
added
Backport
|
Hi @fabiobaltieri! We usually only backport bugfixes, but #64386 is an enhancement request? |
Yeah this is a bit unconventional, not a bugfix per se but since this makes build failure message clearer and there's a fairly high chances downstream users are going to hit this while upgrading, I think it may be worth backporting anyway. What do you folks think? I'm fine with dropping it if anyone feels strongly about it. |
|
Assigning to @kartben since he filed the original issue. |
|
From the original PR:
|
|
Cool by me! Thanks for the feedback. |
Backport dd178ce~2..dd178ce from #64486.
Fixes #64386