lib: newlib: Define _ANSI_SOURCE #52740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Newlib integration to define `_ANSI_SOURCE` in order to prevent Newlib from defining POSIX primitives in its headers when GNU dialect is used (`-std=gnu*`). Newlib `features.h` defines `_DEFAULT_SOURCE` when `__STRICT_ANSI__` is not defined by GCC (i.e. when `-std=gnu*`), which results in the Newlib headers defining POSIX primitives that are in conflict with the POSIX primitives defined by Zephyr. Newlib must not define POSIX primitives unless the feature test macros such as `_POSIX_SOURCE`, `_GNU_SOURCE` and `_DEFAULT_SOURCE` are explicitly defined. Note that `-std=gnu` does not imply `_GNU_SOURCE` or `_DEFAULT_SOURCE` because it is only supposed to instruct the compiler to use the GNU C language dialect (i.e. GNU C language extensions). Refer to the GitHub issue zephyrproject-rtos#52739 for more details. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
newlib_ansisource
branch
from
4c3d514 to
0a9622f
Compare
zephyrbot
requested review from
cfriedt,
enjiamai,
KangJianX and
keith-packard
carlescufi
approved these changes
Dec 2, 2022
stephanosio
added a commit
to stephanosio/nrfconnect-sdk-zephyr
that referenced
this pull request
Dec 2, 2022
This commit updates the Newlib integration to define `_ANSI_SOURCE` in order to prevent Newlib from defining POSIX primitives in its headers when GNU dialect is used (`-std=gnu*`). Newlib `features.h` defines `_DEFAULT_SOURCE` when `__STRICT_ANSI__` is not defined by GCC (i.e. when `-std=gnu*`), which results in the Newlib headers defining POSIX primitives that are in conflict with the POSIX primitives defined by Zephyr. Newlib must not define POSIX primitives unless the feature test macros such as `_POSIX_SOURCE`, `_GNU_SOURCE` and `_DEFAULT_SOURCE` are explicitly defined. Note that `-std=gnu` does not imply `_GNU_SOURCE` or `_DEFAULT_SOURCE` because it is only supposed to instruct the compiler to use the GNU C language dialect (i.e. GNU C language extensions). Refer to the GitHub issue #52739 for more details. Upstream PR: zephyrproject-rtos/zephyr#52740 Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
added a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Dec 2, 2022
This commit updates the Newlib integration to define `_ANSI_SOURCE` in order to prevent Newlib from defining POSIX primitives in its headers when GNU dialect is used (`-std=gnu*`). Newlib `features.h` defines `_DEFAULT_SOURCE` when `__STRICT_ANSI__` is not defined by GCC (i.e. when `-std=gnu*`), which results in the Newlib headers defining POSIX primitives that are in conflict with the POSIX primitives defined by Zephyr. Newlib must not define POSIX primitives unless the feature test macros such as `_POSIX_SOURCE`, `_GNU_SOURCE` and `_DEFAULT_SOURCE` are explicitly defined. Note that `-std=gnu` does not imply `_GNU_SOURCE` or `_DEFAULT_SOURCE` because it is only supposed to instruct the compiler to use the GNU C language dialect (i.e. GNU C language extensions). Refer to the GitHub issue #52739 for more details. Upstream PR: zephyrproject-rtos/zephyr#52740 Signed-off-by: Stephanos Ioannidis <[email protected]>
cfriedt
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Newlib integration to define
_ANSI_SOURCEin order to prevent Newlib from defining POSIX primitives in its
headers when GNU dialect is used (
-std=gnu*).Newlib
features.hdefines_DEFAULT_SOURCEwhen__STRICT_ANSI__is not defined by GCC (i.e. when
-std=gnu*), which results in theNewlib headers defining POSIX primitives that are in conflict with the
POSIX primitives defined by Zephyr.
Newlib must not define POSIX primitives unless the feature test macros
such as
_POSIX_SOURCE,_GNU_SOURCEand_DEFAULT_SOURCEareexplicitly defined.
Note that
-std=gnudoes not imply_GNU_SOURCEor_DEFAULT_SOURCEbecause it is only supposed to instruct the compiler to use the GNU C
language dialect (i.e. GNU C language extensions).
Refer to the GitHub issue #52739 for more details.
Fixes #52739