Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 434508] Bad bit shift operation in drivers/dac/dac_dacx3608.c #81990

Closed
zephyrbot opened this issue Nov 25, 2024 · 0 comments · Fixed by #82441
Closed

[Coverity CID: 434508] Bad bit shift operation in drivers/dac/dac_dacx3608.c #81990

zephyrbot opened this issue Nov 25, 2024 · 0 comments · Fixed by #82441
Assignees
Labels
area: DAC Digital-to-Analog Converter bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/b1def7145fd/drivers/dac/dac_dacx3608.c

Category: Integer handling issues
Function: dacx3608_write_value
Component: Drivers
CID: 434508

Details:

https://github.com/zephyrproject-rtos/zephyr/blob/b1def7145fd/drivers/dac/dac_dacx3608.c#L149

Please fix or provide comments in coverity using the link:

https://scan9.scan.coverity.com/#/project-view/29271/12996?selectedIssue=434508

For more information about the violation, check the Coverity Reference. ()

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the MAINTAINERS file.

@zephyrbot zephyrbot added area: DAC Digital-to-Analog Converter bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Nov 25, 2024
@kartben kartben closed this as completed in 075cb21 Jan 7, 2025
Devansh0210 pushed a commit to Devansh0210/zephyr that referenced this issue Jan 7, 2025
The parameter provided to the `BIT()` macro must be checked so that
the shift operation does not overflow the variable.

Fixes zephyrproject-rtos#81990

Signed-off-by: Martin Jäger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DAC Digital-to-Analog Converter bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants