multipe tests/posix & tests/lib/c_lib/thrd build failures due to missing time.h definitions

[hakehuang]

Describe the bug

• tests/posix/common/portability.posix.common.newlib
• tests/posix/common/portability.posix.common.tls.newlib
• tests/posix/fs/portability.posix.fs.newlib
• tests/posix/fs/portability.posix.fs.tls.newlib
• tests/posix/headers/portability.posix.headers.newlib.with_posix_api
• tests/lib/c_lib/thrd/libraries.libc.c11_threads.newlib
• tests/lib/c_lib/thrd/libraries.libc.c11_threads.newlib_nano

build failure in the following platforms:

• circuitdojo_feather/nrf9160/ns
• actinius_icarus_bee/nrf9160/ns
• [email protected]/nrf9160/ns
• [email protected]/nrf9160/ns
• innblue21/nrf9160/ns
• innblue22/nrf9160/ns
• lpcxpresso55s69/lpc55s69/cpu0/ns
• actinius_icarus_som_dk/nrf9160/ns
• actinius_icarus_som/nrf9160/ns
• mimxrt1010_evk
• mimxrt1024_evk
• mimxrt1015_evk
• mimxrt1020_evk
• mimxrt1040_evk
• mimxrt1060_evk
• mimxrt1050_evk
• mimxrt1060_evk@hyperflash
• mimxrt1060_evkb
• mimxrt1050_evk@qspi
• mimxrt1170_evk@B/mimxrt1176/cm7
• mimxrt1062_fmurt6
• mimxrt1170_evk/mimxrt1176/cm7
• mimxrt1160_evk/mimxrt1166/cm7
• mimxrt1064_evk
• mm_feather
• mimxrt595_evk/mimxrt595s/cm33
• mm_swiftio
• mimxrt685_evk/mimxrt685s/cm33
• nrf5340dk/nrf5340/cpuapp/ns
• nrf5340_audio_dk/nrf5340/cpuapp/ns
• nrf9151dk/nrf9151/ns
• nrf9160dk/nrf9160/ns
• nrf9131ek/nrf9131/ns
• [email protected]/nrf9160/ns
• nrf9161dk/nrf9161/ns
• [email protected]/nrf9161/ns
• raytac_mdbt53_db_40/nrf5340/cpuapp/ns
• raytac_mdbt53v_db_40/nrf5340/cpuapp/ns
• sparkfun_thing_plus/nrf9160/ns
• b_u585i_iot02a/stm32u585xx/ns
• stm32l562e_dk/stm32l562xx/ns
• thingy53/nrf5340/cpuapp/ns
• vmu_rt1170/mimxrt1176/cm7
• bl5340_dvk/nrf5340/cpuapp/ns

To Reproduce
Steps to reproduce the behavior:

twister -i -p mimxrt1170_evk/mimxrt1176/cm7 -s portability.posix.headers.newlib.with_posix_api

Expected behavior
build PASS

Impact
POSIX compatible
~190 failures in weekly CI
Failures in PRs CI when these tests are triggered

Logs and console output

modules/crypto/mbedtls/library/platform_util.c
In file included from zephyr/include/zephyr/posix/time.h:116,
                 from zephyr/include/zephyr/posix/time.h:12,
                 from zephyr/include/zephyr/net/socket_select.h:22,
                 from zephyr/include/zephyr/posix/sys/select.h:10,
                 from zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/sys/types.h:50,
                 from zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/stdio.h:61,
                 from modules/crypto/mbedtls/include/mbedtls/platform.h:58,
                 from modules/crypto/mbedtls/library/platform_util.c:26:
zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/time.h:56:1: error: unknown type name 'clock_t'
   56 | clock_t    clock (void);
      | ^~~~~~~
zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/time.h:30:1: note: 'clock_t' is defined in header '<time.h>'; did you forget to '#include <time.h>'?
   29 | #include <sys/timespec.h>
  +++ |+#include <time.h>
   30 | 
In file included from zephyr/include/zephyr/posix/posix_types.h:15,
                 from zephyr/include/zephyr/posix/time.h:61:
zephyr-sdk-0.16.8/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/sys/_pthreadtypes.h:182:3: error: unknown type name 'clock_t'
  182 |   clock_t  clock;             /* specifiy clock for timeouts */
      |   ^~~~~~~
zephyr/include/zephyr/posix/posix_types.h:76:9: error: unknown type name 'clockid_t'
   76 |         clockid_t clock;
      |         ^~~~~~~~~
zephyr/include/zephyr/posix/time.h:93:19: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
   93 | int clock_gettime(clockid_t clock_id, struct timespec *ts);
      |                   ^~~~~~~~~
      |                   clock_pfd_t
zephyr/include/zephyr/posix/time.h:94:18: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
   94 | int clock_getres(clockid_t clock_id, struct timespec *ts);
      |                  ^~~~~~~~~
      |                  clock_pfd_t
zephyr/include/zephyr/posix/time.h:95:19: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
   95 | int clock_settime(clockid_t clock_id, const struct timespec *ts);
      |                   ^~~~~~~~~
      |                   clock_pfd_t
zephyr/include/zephyr/posix/time.h:96:36: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
   96 | int clock_getcpuclockid(pid_t pid, clockid_t *clock_id);
      |                                    ^~~~~~~~~
      |                                    clock_pfd_t
zephyr/include/zephyr/posix/time.h:98:18: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
   98 | int timer_create(clockid_t clockId, struct sigevent *evp, timer_t *timerid);
      |                  ^~~~~~~~~
      |                  clock_pfd_t
zephyr/include/zephyr/posix/time.h:105:21: error: unknown type name 'clockid_t'; did you mean 'clock_pfd_t'?
  105 | int clock_nanosleep(clockid_t clock_id, int flags,
      |                     ^~~~~~~~~
      |                     clock_pfd_t
In file included from zephyr/include/zephyr/sys/fdtable.h:13,
                 from zephyr/include/zephyr/net/socket_select.h:26:
zephyr/include/zephyr/fs/fs.h:368:1: error: unknown type name 'ssize_t'; did you mean '_ssize_t'?
  368 | ssize_t fs_read(struct fs_file_t *zfp, void *ptr, size_t size);
      | ^~~~~~~
      | _ssize_t
zephyr/include/zephyr/fs/fs.h:389:1: error: unknown type name 'ssize_t'; did you mean '_ssize_t'?
  389 | ssize_t fs_write(struct fs_file_t *zfp, const void *ptr, size_t size);
      | ^~~~~~~
      | _ssize_t
zephyr/include/zephyr/fs/fs.h:409:36: error: unknown type name 'off_t'; did you mean '_off_t'?
  409 | int fs_seek(struct fs_file_t *zfp, off_t offset, int whence);
      |                                    ^~~~~
      |                                    _off_t
zephyr/include/zephyr/fs/fs.h:425:1: error: unknown type name 'off_t'; did you mean '_off_t'?
  425 | off_t fs_tell(struct fs_file_t *zfp);
      | ^~~~~
      | _off_t
zephyr/include/zephyr/fs/fs.h:447:40: error: unknown type name 'off_t'; did you mean '_off_t'?
  447 | int fs_truncate(struct fs_file_t *zfp, off_t length);
      |                                        ^~~~~
      |                                        _off_t
zephyr/include/zephyr/sys/fdtable.h:48:17: error: expected specifier-qualifier-list before 'ssize_t'
   48 |                 ssize_t (*read)(void *obj, void *buf, size_t sz);
      |                 ^~~~~~~
zephyr/include/zephyr/sys/fdtable.h:52:17: error: expected specifier-qualifier-list before 'ssize_t'
   52 |                 ssize_t (*write)(void *obj, const void *buf, size_t sz);
      |                 ^~~~~~~
ninja: build stopped: subcommand failed.```

Environment (please complete the following information):

• OS: (e.g. Linux)
• Toolchain (e.g Zephyr SDK, ...) zephyr-sdk-0.16.8
• Commit SHA or Version used: main after b82b5b0

Additional info
Introduced by #73978
PR is not bisectable

Edited by @aescolar to encompass all cases of the same issue

[cfriedt]

It's not really clear to me how commit a9a909c could affect anything to do with mbedtls or posix headers (so I think there was a misstep in the git bisect, likely missing a west update), but this test does fail to build using the command below on main, so I'll continue to debug.

twister -i -p mimxrt1170_evk/mimxrt1176/cm7 -s portability.posix.headers.newlib.with_posix_api

[cfriedt]

A bisect at my end identified 94d712e as the offending commit, which is also just as arbitrary and unrelated.

The search continues!

[ithinuel]

The bisect I ran points the same PR (#73978) however, the first commit of that PR does not break posix thing but fdtable.c.

The error is:

.../zephyr/lib/os/fdtable.c: In function 'zvfs_rw':
.../zephyr/lib/os/fdtable.c:315:41: error: 'const struct fd_op_vtable' has no member named 'write_offset'; did you mean 'write_offs'?
  315 |                 if (fdtable[fd].vtable->write_offset == NULL) {
      |                                         ^~~~~~~~~~~~
      |                                         write_offs
.../zephyr/lib/os/fdtable.c:319:51: error: 'const struct fd_op_vtable' has no member named 'write_offset'; did you mean 'write_offs'?
  319 |                         res = fdtable[fd].vtable->write_offset(fdtable[fd].obj, buf, sz,
      |                                                   ^~~~~~~~~~~~
      |                                                   write_offs
.../zephyr/lib/os/fdtable.c:327:51: error: 'const struct fd_op_vtable' has no member named 'read_offset'; did you mean 'read_offs'?
  327 |                         res = fdtable[fd].vtable->read_offset(fdtable[fd].obj, buf, sz,
      |                                                   ^~~~~~~~~~~
      |                                                   read_offs
.../zephyr/lib/os/fdtable.c:335:1: error: label 'unlock' defined but not used [-Werror=unused-label]
  335 | unlock:
      | ^~~~~~

the following commits in that PR do affect posix related implementation in various ways so my guess would be that it's more error compounding in what's been reported by @hakehuang

EDIT: this error gets fixed in a later commit in that same PR: cfriedt@88e631d#diff-c5e475ef95ce582f4a29b7c9669794a903686ea1d141f6095239e51176c99a5e

EDIT2: after fixing this error in the commit that introduced it, a new bisect points to df00883 which also isn't directly related to the error reported here.
Not having all commits to build makes git bisect a bit less useful to identify the offending commit.