Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent typo in dts/arm/rpi_pico/rp2040.dtsi #70959

Closed
ThreeEights opened this issue Apr 1, 2024 · 1 comment · Fixed by #70958
Closed

Apparent typo in dts/arm/rpi_pico/rp2040.dtsi #70959

ThreeEights opened this issue Apr 1, 2024 · 1 comment · Fixed by #70958
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) priority: low Low impact/importance bug

Comments

@ThreeEights
Copy link
Contributor

ThreeEights commented Apr 1, 2024

Describe the bug
The "resets" for i2c1 in dts/arm/rpi_pico/rp2040.dtsi is set to RPI_PICO_RESETS_RESET_I2C0, but that is the reset bit for i2c0.

Expected behavior
The correct (local) define for the reset bit for i2c1 is RPI_PICO_RESETS_RESET_I2C1.

Impact
This appears to be a minor issue, but can affect the interaction between the two I2C devices.

Additional context
Information on the RESET register is in section 2.14 of the RP2040 Datasheet.

@ThreeEights ThreeEights added the bug The issue is a bug, or the PR is fixing a bug label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Hi @ThreeEights! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

ThreeEights added a commit to ThreeEights/zephyr that referenced this issue Apr 1, 2024
It was RPI_PICO_RESETS_RESET_I2C0, but should be
RPI_PICO_RESETS_RESET_I2C1.

Fixes: zephyrproject-rtos#70959

Signed-off-by: Steve Boylan <[email protected]>
@nordicjm nordicjm added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Apr 2, 2024
@nashif nashif added the priority: low Low impact/importance bug label Apr 2, 2024
fabiobaltieri pushed a commit that referenced this issue Apr 3, 2024
It was RPI_PICO_RESETS_RESET_I2C0, but should be
RPI_PICO_RESETS_RESET_I2C1.

Fixes: #70959

Signed-off-by: Steve Boylan <[email protected]>
Lahyllas pushed a commit to tsnlab/zephyr that referenced this issue May 16, 2024
It was RPI_PICO_RESETS_RESET_I2C0, but should be
RPI_PICO_RESETS_RESET_I2C1.

Fixes: zephyrproject-rtos#70959

Signed-off-by: Steve Boylan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants