Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: Update supported python versions #752

Merged
merged 2 commits into from
Oct 15, 2024
Merged

.github: Update supported python versions #752

merged 2 commits into from
Oct 15, 2024

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Oct 11, 2024

Python 3.8 is end-of-life, removed.
Python 3.13 is released, added.

@pdgendt pdgendt requested review from carlescufi and marc-hb October 11, 2024 10:18
@pdgendt pdgendt linked an issue Oct 11, 2024 that may be closed by this pull request
CI failing on Windows - Python 3.13 #753
Closed
@pdgendt pdgendt added this to the v1.3.0 milestone Oct 11, 2024
@pdgendt pdgendt force-pushed the python-bump branch 2 times, most recently from b981428 to 40941a9 Compare October 11, 2024 12:07
marc-hb
marc-hb reviewed Oct 11, 2024
View reviewed changes
src/west/manifest.py Outdated Show resolved Hide resolved
@marc-hb
Copy link
Collaborator

marc-hb commented Oct 11, 2024 •
edited
Loading

Why did Python 3.13 make that change and what does a "drive-free" path that starts with a slash do on Windows?

@marc-hb
Copy link
Collaborator

marc-hb commented Oct 11, 2024

I found a good answer in this 2007 (!) bug https://bugs.python.org/issue1669539

Before 3.13:

>>> s = '\\Python25'
>>> os.path.isabs(s)
True
>>> os.path.abspath(s)
'C:\\Python25'
>>> os.chdir('d:')
>>> os.path.abspath(s)
'D:\\Python25'

If this can jump between C: and D: then I agree it's not "absolute".

marc-hb
marc-hb reviewed Oct 11, 2024
View reviewed changes
src/west/manifest.py Outdated Show resolved Hide resolved
@pdgendt
manifest: Fix absolute path checking on windows for Python 3.13
fdfda1a 
Python 3.13 changed the behavior for os.path.isabs
https://docs.python.org/3/library/os.path.html#os.path.isabs

Prevent absolute paths that start with a '/'.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt
.github: Update supported python versions
c5aa91d 
Python 3.8 is end-of-life, removed.
Python 3.13 is released, added.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt pdgendt merged commit c3aadf5 into zephyrproject-rtos:main Oct 15, 2024
16 checks passed
@pdgendt pdgendt deleted the python-bump branch October 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-hb marc-hb marc-hb approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

CI failing on Windows - Python 3.13
2 participants
@pdgendt @marc-hb