app: project: Allow to diff against manifest revision #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an argument to the west diff command that allows to set the manifest revision as the merge-base. Signed-off-by: Pieter De Gendt <[email protected]>
Run the diff command with --manifest argument. Signed-off-by: Pieter De Gendt <[email protected]>
aasinclair
approved these changes
Jul 31, 2024
carlescufi
approved these changes
Aug 27, 2024
|
While I'm truly in awe of @pdgendt 's west productivity, I have concerns this one was a bit rushed... why
See for instance codecov/codecov-bash#83 |
|
Right, I've created a follow-up PR that simplifies it: #728 |
marc-hb
reviewed
Oct 8, 2024
| @@ -792,9 +794,10 @@ def do_run(self, args, ignored): | |||
| for project in self._cloned_projects(args, only_active=not args.all): | |||
| # Use paths that are relative to the base directory to make it | |||
| # easier to see where the changes are | |||
| merge_base = ['--merge-base', project.revision] if args.manifest else [] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an argument to the west diff command that allows to set the manifest revision as the merge-base.