kconfig: remove PICOLIBC_MODULE, introduce PICOLIBC_USE_MODULE #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove PICOLIBC_MODULE as it is not used. Introduce PICOLIBC_USE_MODULE as a hidden symbol. PICOLIBC_USE_MODULE is the actual Kconfig symbol used in the CMake code to decide if Picolibc should be build. The symbol is promptless to allow external users of the module, such as Zephyr itself, to setup rules / dependencies as to when Picolibc should be built as a module. Signed-off-by: Torsten Rasmussen <[email protected]>
keith-packard
approved these changes
Jan 13, 2023
keith-packard
pushed a commit
that referenced
this pull request
Jan 21, 2024
This ensures that running `b _ctrap; c; bt` inside gdb shows the right
backtrace. If we jump without setting ra gdb gets confused about the
backtrace since we don't have the right cfi directives inside ctrap.
This does not result in any downsides since ra has already been saved.
Previously we had to set a breakpoint just before this jump to get a
correct backtrace, now it's possible to set a breakpoint in _ctrap
instead:
```
Reading symbols from test/test-fopen...
Breakpoint 1 at 0x80000058: file ../../picolibc/picocrt/machine/riscv/crt0.c, line 84.
Remote debugging using :1234
0x0000000000001000 in ?? ()
Continuing.
Breakpoint 1, _ctrap (fault=0x805feee8) at ../../picolibc/picocrt/machine/riscv/crt0.c:84
84 printf("RISCV fault\n");
#0 _ctrap (fault=0x805feee8) at ../../picolibc/picocrt/machine/riscv/crt0.c:84
#1 0x00000000800001c4 in _trap () at ../../picolibc/picocrt/machine/riscv/crt0.c:168
#2 0x00000000800013d0 in fclose (f=0x804008c0) at ../../picolibc/newlib/libc/tinystdio/fclose.c:39
#3 0x0000000080000680 in main () at ../../picolibc/test/test-fopen.c:85
(gdb)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keith-packard maybe you prefer to take this directly here ? : https://github.com/picolibc/picolibc
Remove PICOLIBC_MODULE as it is not used.
Introduce PICOLIBC_USE_MODULE as a hidden symbol. PICOLIBC_USE_MODULE is the actual Kconfig symbol used in the CMake code to decide if Picolibc should be build.
The symbol is promptless to allow external users of the module, such as Zephyr itself, to setup rules / dependencies as to when Picolibc should be built as a module.
Signed-off-by: Torsten Rasmussen [email protected]