Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regular openthread upmerge 3873c6f #158

Merged
merged 250 commits into from
Jun 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
250 commits
Select commit Hold shift + click to select a range
5a4fe05
[mle] generate challenge for "Child Update Request" early (#9850)
sarveshkumarv3 Feb 16, 2024
33574ad
[tools] add missing tcat ble client files (#9857)
maciejbaczmanski Feb 16, 2024
08d21f1
[netdiag] add support for Vendor App URL TLV (#9816)
abtink Feb 20, 2024
6cfe14c
[cli] add references to CoAP concepts guide from CLI (#9856)
jrhodie Feb 20, 2024
00f22b5
[netdiag] update comments and fix style (#9866)
abtink Feb 21, 2024
3aa3cbc
[ip6] add multicast forwarding restrictions to host (#9863)
sunytt Feb 21, 2024
a0d805c
[cli] style fixes & remove core defined error constants (#9868)
abtink Feb 22, 2024
f0b6fce
[cli-tcat] define `VendorInfo` as a member variable (#9869)
abtink Feb 22, 2024
41d05c2
[core] use `NumericLimits<>` constants (#9875)
abtink Feb 26, 2024
ac417bd
[cli] add `@moreinfo` Doxygen tags to reference CoAPS Concepts Guide …
jrhodie Feb 26, 2024
aff159f
[link-quality] prevent overflow in `LqiAverager` calculation (#9876)
abtink Feb 27, 2024
37fef5e
[spinel] drop received frames between RCP disable and reset (#9793)
aashu216 Feb 28, 2024
acfdcfd
[message] track received `ThreadLinkInfo` in `Message` metadata (#9878)
abtink Feb 28, 2024
5960215
[simulation] add `simul_utils.h` for socket operation helpers (#9879)
abtink Feb 28, 2024
b9dcdbc
[cli] add documentation for `nexthop` command in `README.md` (#9882)
abtink Feb 28, 2024
41526d5
github-actions: bump codecov/codecov-action from 3.1.4 to 4.0.2 (#9877)
dependabot[bot] Mar 1, 2024
badfaaf
github-actions: bump github/codeql-action from 3.23.2 to 3.24.6 (#9890)
dependabot[bot] Mar 4, 2024
27eb8ed
[posix] fix member var access from static `CreateIcmp6Socket()` (#9887)
abtink Mar 4, 2024
08a7600
[string] return `0` if `nullptr` is passed to `StringLength` (#9886)
maciejbaczmanski Mar 4, 2024
88b2b5c
[posix] enable building `infra_if.cpp` on macOS (#9891)
abtink Mar 5, 2024
44c3906
[border-agent] mechanism to use ephemeral key (#9435)
abtink Mar 5, 2024
d63da4f
[posix] add missing header guards, style fixes (#9892)
abtink Mar 6, 2024
125e726
[routing-manager] delay sending RAs until after initial policy evalua…
abtink Mar 6, 2024
036f6eb
[posix] add otSysCliInitUsingDaemon API (#9897)
morningboata Mar 6, 2024
39fcc5e
[simulation] implement `otPlatInfraIf` APIs in simulation platform (#…
abtink Mar 6, 2024
5b88759
[toranj-config] disable `OT_BORDER_ROUTING` on NCP builds (#9907)
abtink Mar 8, 2024
c66d91b
[key-manager] update how key guard time is determined and applied (#9…
abtink Mar 8, 2024
53382ec
[srp-server] add snoop cache entries for registered host addresses (#…
abtink Mar 8, 2024
518a849
[test] add `test_key_rotation_and_key_guard_time` (#9906)
abtink Mar 8, 2024
2b4b2cf
[docs] add documentation for CLI `dataset updater` command (#9905)
abtink Mar 11, 2024
e8f769f
github-actions: bump actions/upload-artifact from 4.2.0 to 4.3.1 (#9914)
dependabot[bot] Mar 11, 2024
8e9d58f
[misc] remove stale forward declaration (#9911)
Irving-cl Mar 11, 2024
be06d7c
[daemon] always initialize the OT CLI when setting up the daemon (#9919)
superwhd Mar 12, 2024
2e24098
[posix] add IPv6 address helper functions in `Ip6Utils` (#9917)
abtink Mar 12, 2024
ec7781a
[thread-cert] set device mode in `test_mle_msg_key_seq_jump` (#9921)
jwhui Mar 12, 2024
8769898
[tests] fix `test_manual_maddress.py` (#9923)
superwhd Mar 13, 2024
c4d7859
[posix] ensure module names are included in platform logs (#9920)
abtink Mar 13, 2024
cf6dcc5
[routing-manager] construct RA dynamically using `Heap::Array` (#9924)
abtink Mar 13, 2024
3ebc3d3
[simulation] allow specify local host (#9925)
bukepo Mar 13, 2024
e379f7c
[mle] disable MLE retransmissions when detaching (#9929)
jwhui Mar 14, 2024
542be0f
[thread-cert] use `ROUTER_STARTUP_DELAY` in `test_detach` (#9933)
jwhui Mar 14, 2024
4c34a0e
[test] enhance `test_netdata_publisher` robustness (#9932)
abtink Mar 14, 2024
ff3cc7e
[posix] remove use of core-internal types in `netif.cpp` platform (#9…
abtink Mar 14, 2024
c89d4f0
[routing-manager] update use of `Ip6::Nd::Option` enumerator (#9931)
abtink Mar 14, 2024
9d6321b
[lib] include `(void)` in function prototype in `reset_util.h` (#9934)
abtink Mar 14, 2024
148fa47
[thread-cert] use `unittest` assert methods (#9936)
jwhui Mar 15, 2024
8b906eb
[routing-manager] simplify `Ip6::Nd` type usage (#9938)
abtink Mar 15, 2024
51ab865
github-actions: bump docker/setup-buildx-action from 3.0.0 to 3.2.0 (…
dependabot[bot] Mar 18, 2024
f917a53
[coap] fix copying option (#9894)
eeumay Mar 22, 2024
3ae275f
[simulation] add simulation tests framework for tcat (#9724)
canisLupus1313 Mar 22, 2024
7d6580e
[cli] move `Process{Get/Set/Enable/Disable}` methods to Utils class (…
Irving-cl Mar 22, 2024
8f379a6
[test] simplify `test_pskc` unit test (#9952)
abtink Mar 22, 2024
90adc86
[mle] retain direct child cache entries on Addr Solicit Response TX (…
abtink Mar 22, 2024
32bef9b
[mle] simplify `HandleTimeTick()` code related to aging routers (#9955)
abtink Mar 25, 2024
681d08d
[spinel] extract log module from radio spinel (#9957)
Irving-cl Mar 25, 2024
97f5bbb
[config] update docs for `SED_BUFFER_SIZE` & `SED_DATAGRAM_COUNT` (#9…
abtink Mar 25, 2024
7028be6
github-actions: bump actions/download-artifact from 4.1.1 to 4.1.4 (#…
dependabot[bot] Mar 25, 2024
13ab3a6
[version] introduce `OT_THREAD_VERSION_1_4` (#9946)
suveshpratapa Mar 25, 2024
09aa963
[netdata] add `FindRlocs()` to retrieve RLOC16 of entries (#9961)
abtink Mar 25, 2024
4db6520
[channel-manager] add local csl channel selection on SSED (#9641)
martinzi Mar 25, 2024
4545daf
[routing-manager] employ RA hash tracking to detect self-originating …
abtink Mar 26, 2024
8c37539
[cli] add `OutputNetworkData()` (#9965)
abtink Mar 26, 2024
dcde882
[test] add `tcat` unit tests (#9953)
maciejbaczmanski Mar 26, 2024
d237cd2
[routing-manager] set extra options to append to emitted RAs (#9945)
abtink Mar 26, 2024
8de3298
[netdata] refactor `MutableNetworkData` methods for code organization…
abtink Mar 27, 2024
7d4a1f8
[mle] include child RLOC16 in the logs from `HandleTimeTick()` (#9968)
abtink Mar 27, 2024
7271b19
[cli] fix CoAP response code for POST 2.03 -> 2.04 per RFC 7252 (#9971)
EskoDijk Mar 27, 2024
34a0b0d
[mle] improve MLE module comments (#9972)
abtink Mar 27, 2024
58b230f
[cli] `netdata show` to support filtering by RLOC16 (#9969)
abtink Mar 27, 2024
911f0d5
[netata] simplify `RemoveTemporaryData()` (#9975)
abtink Mar 28, 2024
37144f0
[mesh-forwarder] update `CheckReachablity()` to handle malformed mess…
abtink Mar 28, 2024
1fb1d9a
github-actions: bump actions/checkout from 4.1.1 to 4.1.2 (#9982)
dependabot[bot] Apr 1, 2024
d099d78
[doc] use space char instead of tabs in `ot_config_doc.h` (#9983)
abtink Apr 2, 2024
0e36799
[link-metrics] fix race condition (#9986)
Irving-cl Apr 2, 2024
843db1e
[srp-server] retry other ports when failing to `prepareSocket` (#9981)
superwhd Apr 3, 2024
a3e8041
[mle] simplify `CheckReachablity()` (#9989)
abtink Apr 3, 2024
38418ae
[ip6] allow delivering RLOC/ALOC traffic to host (#9987)
bukepo Apr 3, 2024
875e71e
[dataset] define `Dataset::Tlvs` type (#9991)
abtink Apr 4, 2024
244c223
[srp-sever] add `LogError()` (#9992)
abtink Apr 4, 2024
65bc830
[test] add tests for multi-BR network resilience during BR removal (#…
abtink Apr 4, 2024
223935b
[logging] introduce `LogWarnOnError()` for standardized error logging…
abtink Apr 5, 2024
e3f97e2
[netdata-publisher] distinguish SRP/DNS unicast entries (#9937)
abtink Apr 5, 2024
b146766
[plat-utils] enhance `otMacFrameDoesAddrMatch()` (#9997)
abtink Apr 5, 2024
a5c17b7
[mle] MTD to handle udp time sync message (#9978)
DaveLacerte Apr 5, 2024
65eac6f
[instance] support get multi instance reference or index (#9947)
gytxxsy Apr 9, 2024
8212acd
[spinel] add time sync feature to the spinel (#9977)
DaveLacerte Apr 9, 2024
5c6b832
[utils] implement Verhoeff checksum calculation and validation (#9966)
abtink Apr 9, 2024
6de5cd8
github-actions: bump actions/upload-artifact from 4.2.0 to 4.3.1 (#10…
dependabot[bot] Apr 9, 2024
bf41332
[mdns] add native mDNS support in OT (#9797)
abtink Apr 9, 2024
51b94bb
[dataset] `GenerateRandom()` to build network name using `StringWrite…
abtink Apr 10, 2024
30aa3e8
[message] introduce `RemoveFooter()` (#10012)
abtink Apr 10, 2024
423c0be
[dataset] add `ApplyConfiguration()` overload without default paramet…
abtink Apr 11, 2024
d7b5939
[dataset] define template method to check/get/set components (#10018)
abtink Apr 11, 2024
3b27202
[dataset] use `Tlv::Find<>()` to check commissioner session ID (#10019)
abtink Apr 11, 2024
9d852a3
[udp] add DHCP ports to `ShouldUsePlatformUdpFunction` (#10017)
marius-preda Apr 11, 2024
f72f27f
[daemon] avoid using `defined(__ANDROID__)` macro in `daemon.cpp` (#1…
superwhd Apr 12, 2024
d0f6d17
[dnssd-server] remove unused private method (#10024)
abtink Apr 12, 2024
d32c68d
github-actions: bump docker/login-action from 3.0.0 to 3.1.0 (#10029)
dependabot[bot] Apr 15, 2024
f68eda9
[dataset] simplify `DatasetManager::HandleGet()` & `SendGetResponse()…
abtink Apr 15, 2024
43cb7a0
[dataset] enforce maximum delay timer value and improve handling (#10…
abtink Apr 15, 2024
23b3641
[mle] restart role transition timeout from `SetRouterEligible(true)` …
abtink Apr 16, 2024
a234add
[cli] update README files to clarify a Commissioner is used for chang…
EskoDijk Apr 16, 2024
cf58985
[spinel] breakdown radio spinel (#10025)
Irving-cl Apr 17, 2024
8692f2f
[cmake] add `OT_BORDER_AGENT_EPSKC` in CMake options (#10034)
abtink Apr 17, 2024
b6a1dc8
[tests] enhance expect test for link metrics manager feature (#10035)
Irving-cl Apr 17, 2024
be7d36e
[dns] add `Name::StripName()` and support in-place `ExtractLabels()` …
abtink Apr 17, 2024
fa64771
[dataset] use `IsActiveDataset()/IsPendingDataset()` for type checks …
abtink Apr 18, 2024
2199db8
[dataset] simplify `AppendMleDatasetTlv()` (#10043)
abtink Apr 18, 2024
4c96151
[logging] fix print format when enabling csl debug (#10045)
suveshpratapa Apr 18, 2024
59572ef
[icmp] add `OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY` to `otIcmp6EchoMode…
sunytt Apr 19, 2024
4737231
[dnssd] allow `Dnssd` platform to use native OT mDNS modules (#9944)
abtink Apr 19, 2024
ba7a6ad
github-actions: bump actions/setup-python from 5.0.0 to 5.1.0 (#10052)
dependabot[bot] Apr 22, 2024
7ec0257
[zephyr] add module name (#10041)
Jappie3 Apr 22, 2024
9af7203
[routing-manager] add support for to use a prefix received from DHCPv…
marius-preda Apr 22, 2024
9681690
[mdns] add APIs to iterate over registered host/service/key entries (…
abtink Apr 22, 2024
de9f978
[mesh-diag] fix a typo in a variable name (#10056)
ZhangLe2016 Apr 23, 2024
b3d300e
[dhcp] add callback to notify DHCPv6 PD state change (#9926)
sherysheng Apr 23, 2024
19dc5ce
[spinel] fix spinel RCP min host api version cap bug (#10057)
lmnotran Apr 24, 2024
ade9c2b
[spinel] restore the source match feature setting (#10055)
zhanglongxia Apr 24, 2024
79a6a85
[dataset] add generic `Read<Tlv>()` methods, refactor timestamp (#10059)
abtink Apr 25, 2024
9a9853b
[dataset] relocate `IsTlvValid()` to `Dataset` (#10060)
abtink Apr 25, 2024
93f3113
[link-metrics] add cli command to show link metrics manager state (#1…
Irving-cl Apr 25, 2024
6312456
[cli] add cli toggle (for test harness) to accept tmf udp messages fr…
suveshpratapa Apr 26, 2024
7a77368
[dataset] simplify `DatasetManager::HandleSet()` (#10063)
abtink Apr 26, 2024
ca45026
[callback] add `InvokeAndClearIfSet()` helper (#10064)
abtink Apr 26, 2024
20a6e88
[dataset] update `SendGetRequest()` to use `TlvList` array (#10066)
abtink Apr 26, 2024
2408c89
[test] add a CMake macro to simplify adding unit tests (#10067)
abtink Apr 26, 2024
502797c
[spinel] add support for logging crash dumps (#10061)
lmnotran Apr 29, 2024
efb80c0
[routing-manager] exclude on-link prefixes with short preferred lifet…
abtink Apr 29, 2024
e89b989
[cli] fix ifdef guard (#10068)
Irving-cl Apr 29, 2024
0884a1b
[dtls] fix undesired kernel filtering of connected UDP (#10069)
wgtdkp Apr 29, 2024
f049648
github-actions: bump github/codeql-action from 3.24.6 to 3.25.3 (#10077)
dependabot[bot] Apr 29, 2024
da72435
[cli] fix namespace usage (#10088)
Irving-cl Apr 29, 2024
0c6c2fe
[dataset] define `MgmtSetCallback` type (#10120)
abtink Apr 30, 2024
3bf281d
[cli] move a few static util methods to `Cli::Utils` class (#10138)
Irving-cl May 1, 2024
9e4cbb8
[spinel] breakdown posix radio module (#10051)
Irving-cl May 2, 2024
2b65a63
[routing-manager] update and simplify comments (#10141)
abtink May 2, 2024
3517e6c
[routing-manager] remove unused method (#10142)
abtink May 2, 2024
f404a22
[spinel] remove `mIsCoprocessorReady` flag check (#10144)
aashu216 May 2, 2024
b8f036a
[simulation] remove example log lines from `otPlatLogCrashDump()` (#1…
abtink May 2, 2024
485cb18
[dataset] add `ValidateTlvs()`, helper methods, and unit test (#10111)
abtink May 2, 2024
d8e3e83
[dataset] simplify `SendSetRequest` (#10135)
abtink May 2, 2024
922059c
[dataset] simplify dataset manager `MGMT_SET` request handling (#10139)
abtink May 2, 2024
ee83d45
[cli] add `br pd omrprefix` command to display DHCPv6 PD OMR prefix (…
abtink May 3, 2024
0a16ece
[style] add comment to indicate the which conditional endif is associ…
Irving-cl May 6, 2024
35a777a
[cli] fix `ipaddr` and `ipmaddr` commands in debug cli (#10200)
lanyuwen May 6, 2024
973e657
github-actions: bump codecov/codecov-action from 4.0.2 to 4.3.1 (#10195)
dependabot[bot] May 6, 2024
42ccf28
[routing-manager] ensure correct handling of shorter PD prefix (#10145)
abtink May 6, 2024
6f0b763
[routing-manager] enhance and streamline `PdPrefixManager` (#10146)
abtink May 7, 2024
83af14a
[dataset] send 'reject' response to `MGMT_SET` on non-leader (#10148)
abtink May 7, 2024
383d0d2
[routing-manager] add `CalculateExpirationTime()` (#10207)
abtink May 7, 2024
00f7c31
[spinel] move definition of coprocessor type to `lib/spinel` (#10208)
Irving-cl May 8, 2024
226f239
[owning-list] add `RemoveAndFreeAllMatching()` to `OwningList` class …
abtink May 8, 2024
8e3f51d
[dns] add checks for multi-label looped compressed DNS names (#10215)
abtink May 9, 2024
74573b5
[routing-manager] use `OwningList` for `Router` and `Entry` lists (#1…
abtink May 9, 2024
0b11482
[spinel] only request crash logs on RCP recovery if capable (#10213)
lmnotran May 9, 2024
1fceb22
[cli] add UDP socket openness check before sending with `udp send` (#…
feherdave May 9, 2024
7cc636c
github-actions: bump ossf/scorecard-action from 2.3.1 to 2.3.3 (#10225)
dependabot[bot] May 13, 2024
39ce811
[simulation] support simulating radio over IPv6 (#10194)
bukepo May 13, 2024
68b8c88
[routing-manager] introduce `RoutePrefix` and `OnLinkPrefix` types (#…
abtink May 13, 2024
f12785d
[dataset] add support for handling `MGMT_ACTIVE_REPLACE` on leader (#…
abtink May 13, 2024
a074684
[clang-format] accept different patch versions of `clang-format` (#10…
suveshpratapa May 14, 2024
e47973a
[routing-manager] add section comments (#10228)
abtink May 14, 2024
e27885e
[routing-manager] track origin of received RA messages (#10229)
abtink May 14, 2024
83e2732
[dataset] simplify dataset `Save()` methods (#10227)
abtink May 14, 2024
02acc48
[routing-manager] ignore checksum in RA hash calculation (#10230)
abtink May 14, 2024
0cd21e6
[posix] add return of co-processor type in otSysInit and allow posix …
Irving-cl May 15, 2024
f66f095
[test] fix description for `test-028-border-agent-ephemeral-key.py` (…
abtink May 15, 2024
4fe428d
[network-data] optimize `ContainsOmrPrefix()` (#10239)
abtink May 15, 2024
6f0b62f
[gitignore] ignore files genereated by running toranj unit tests (#10…
Irving-cl May 15, 2024
f97a01c
[simulation] rename local host to local interface (#10241)
bukepo May 15, 2024
6724a0b
[gitignore] add more temp files to `.gitignore` (#10243)
abtink May 15, 2024
0a4d6d3
[routing-manager] utilize `Network::Leader::ContainsOmrPrefix()` (#10…
abtink May 15, 2024
848de78
[dataset] enforce successful Dataset saves in non-volatile (#10237)
abtink May 16, 2024
72f2df8
[gitignore] do not ignore .cmake files (#10247)
Irving-cl May 16, 2024
f15dbd6
[dataset] add `ContainsAllTlvs()` helper method (#10249)
abtink May 16, 2024
c8e2eb8
[mle] add helper method `SetLeaderData(const LeaderData &)` (#10245)
abtink May 16, 2024
8c92497
[secure-transport] remove redundant null check (#10254)
jwhui May 17, 2024
16ee66a
[routing-manager] fix received NA message min length check (#10256)
abtink May 17, 2024
1ab2919
[routing-manager] signal table change on M/O flag update of routers (…
abtink May 17, 2024
be10913
[spinel] remove dependency on ot core (#10212)
Irving-cl May 17, 2024
beb3cc1
[mle] simplify `HandleLeaderData()` (#10248)
abtink May 17, 2024
0f9419f
[routing-manager] rename `DiscoveredPrefixTable` to `RxRaTracker` (#1…
abtink May 17, 2024
ee1ae6c
[tests] do not build unit tests in oss-fuzz (#10259)
jwhui May 17, 2024
213aede
[dataset] move Active Dataset replacement check in `PendingDatasetMan…
abtink May 17, 2024
63442f7
[dataset] move `Read()` overload implementations to `DatasetManager` …
abtink May 17, 2024
67a2627
[routing-manager] move tracking of local RA header to `RxRaTracker` (…
abtink May 17, 2024
6444157
[mbedtls] remove config workaround (#10263)
jwhui May 18, 2024
42d567d
[mdns] ensure callback is invoked when registering host with no addre…
abtink May 20, 2024
e36c513
[routing-manager] move handling of prefix stale timer to `RxRaTracker…
abtink May 20, 2024
c1add34
[dataset-manager] combine `protected` and `private` sections (#10267)
abtink May 20, 2024
e529303
[dataset-manager] ensure `mDelayTimer` is stopped when no Pending Dat…
abtink May 20, 2024
10ccec2
github-actions: bump docker/setup-buildx-action from 3.2.0 to 3.3.0 (…
dependabot[bot] May 20, 2024
0ce49fc
[utils] fix build when `OPENTHREAD_CONFIG_CHANNEL_MONITOR_ENABLE=0` (…
aashu216 May 20, 2024
6e595de
[dataset-manager] track local dataset in `DatasetManager` (#10275)
abtink May 21, 2024
153e256
[mdns] include additional records along with sub-type PTR answer (#10…
abtink May 21, 2024
71bd987
[posix] add spinel driver getter to allow external app to access (#10…
Irving-cl May 21, 2024
3cb4540
[routing-manager] move decision to process PIO/RIO to `RxRaTracker` (…
abtink May 21, 2024
b01b262
[routing-manager] track and report last update time of routers (#10244)
abtink May 21, 2024
8b04e9c
[dataset] move `ApplyConfiguration()` to `DatasetManager` (#10280)
abtink May 21, 2024
f752153
[routing-manager] update and simplify decisions for processing PIO/RI…
abtink May 22, 2024
0b503a0
[dataset] simplify `Clear()` methods (#10283)
abtink May 22, 2024
31ac626
[routing-manager] track whether a discovered router is local device (…
abtink May 22, 2024
a57d927
[string] add `ParseDigit()`, `ParseHexDigit()`, and other helper func…
abtink May 22, 2024
1b2ad3d
[spinel] parse correct RcpMinHostApiVersion capability (#10285)
zhanglongxia May 23, 2024
e7535f7
[mle] update router table after adding a new neighbor (#10288)
gytxxsy May 23, 2024
a46bdd9
[dataset-manager] simplify `Restore()` (#10290)
abtink May 24, 2024
0abc8d7
[routing-manager] simplify how `RxRaTracker` handles local on-link pr…
abtink May 24, 2024
a54f4c4
[dataset] simplify `IsSubsetOf()` (#10292)
abtink May 25, 2024
ef10dec
[mle] fix warning with storedCount (#10301)
LuDuda May 28, 2024
10cff14
[timer] add `NextFireTime` class (#10295)
abtink May 28, 2024
330b175
github-actions: bump actions/checkout from 4.1.2 to 4.1.6 (#10299)
dependabot[bot] May 28, 2024
6db2d58
[cli] fix memory leak on TCP init failure (#10300)
LuDuda May 27, 2024
59b87d6
[fuzz] fix typo and enable SRP Advertising Proxy (#10300)
LuDuda May 27, 2024
c96e3b9
[mbedtls] migrate to MbedTLS v3.6.0 (#10286)
LuDuda May 21, 2024
27f1dbc
[mbedtls] modify GitHub workflows to test MbedTLS v2.28.8 (#10286)
LuDuda May 21, 2024
1336da4
[mbedtls] optimize AES configuration (#10286)
LuDuda May 21, 2024
2841ca0
[dataset-updater] enhance `DatasetUpdater` (#10293)
abtink May 30, 2024
0b71673
[mdns] use `NextFireTime` class (#10304)
abtink May 30, 2024
8d38fc7
[dso] use `NextFireTime` (#10306)
abtink May 30, 2024
bef804c
[utils] add API to reset/clear linked list of enh-ack link metrics (#…
aashu216 May 30, 2024
d2e74dc
[routing-manager] fix lifetime management of PD prefix (#10310)
abtink May 30, 2024
edad0f9
[radio] update `otPlatRadioSetRxOnWhenIdle` documentation (#10307)
edmont May 30, 2024
ca7dd82
[mle] simplify signaling of DUA address change (#10296)
abtink May 31, 2024
7b08e9a
[routing-manager] update and simplify RA beacon timing (#10309)
abtink May 31, 2024
4951dee
[routing-manager] update stale time calculation for local RA header (…
abtink May 31, 2024
d95b44c
[mle] add helper methods to `RxMessage` (#10319)
abtink May 31, 2024
26b7416
[routing-manager] fix and enhance prefix stale time calculation (#10317)
abtink Jun 3, 2024
b2f17f8
github-actions: bump actions/download-artifact from 4.1.4 to 4.1.7 (#…
dependabot[bot] Jun 3, 2024
8fc67f3
[meshcop] update `Timestamp::AdvanceRandomTicks()` (#10320)
abtink Jun 3, 2024
e1918b3
[encoding] declare `HostSwap()` functions as `constexpr` (#10326)
abtink Jun 3, 2024
b4ec4ce
[mle] add `ConnectivityTlv::IsSingleton()` (#10329)
abtink Jun 4, 2024
70bad1d
[mbedtls] enable MBEDTLS_OID_C when MBEDTLS_PK_PARSE_C is enabled (#1…
LuDuda Jun 4, 2024
ea61703
[spinel] remove including openthread-core-config.h (#10322)
Irving-cl Jun 4, 2024
59e202c
[mbedtls] remove `-Wno-unused-but-set-variable` (#10336)
jwhui Jun 4, 2024
791ee87
[dataset-manager] enhance starting of Pending Dataset delay timer (#1…
abtink Jun 4, 2024
d1506ab
[routing-manager] update stale time constant to 10 minute (#10330)
abtink Jun 4, 2024
d11d705
[ip6] do not report an error for disabled host loopback (#10339)
konradderda Jun 4, 2024
d4ec371
[mdns] add APIs to iterate over browsers and resolvers (#10140)
abtink Jun 4, 2024
0d5f41d
[mle] minor enhancements to `HandleParentResponse()` (#10331)
abtink Jun 4, 2024
5bb3667
[dataset] add `WriteTimestamp()` and `RemoveTimestamp()` (#10333)
abtink Jun 4, 2024
fcd3c5c
[timestamp] add `IsValid()` and comparison operator overloads (#10325)
abtink Jun 4, 2024
b5b17ba
[mle] allow appending pending timestamp TLV with zero seconds (#10327)
abtink Jun 4, 2024
b776454
[mle] add `Mle::TxMessage::AppendDatasetTlv()` (#10340)
abtink Jun 5, 2024
18f7bc3
[mle] add `TxMessage::AppendActiveAndPendingTimestampTlvs()` (#10341)
abtink Jun 5, 2024
d6eb56c
[routing-manager] enhance `TestPrefixStaleTime()` (#10342)
abtink Jun 5, 2024
89b4217
[posix] add RCP capability diag module (#10335)
zhanglongxia Jun 6, 2024
cdeb02b
[posix] extract co-processor init out of otSysInit (#10344)
Irving-cl Jun 6, 2024
398df8c
[tcat] implement tcat advertisement (#9858)
canisLupus1313 Jun 6, 2024
3873c6f
[tcat] add TCAT Commissioner / Device certs for Thread certification…
EskoDijk Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[icmp] add OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY to `otIcmp6EchoMode…
…` (#10014)

When an icmp echo request is sent to rloc/aloc address of a Thread
device, OT replies to the packet. The packet is also passed to host
and the kernel may reply to the echo request. This would cause 2 echo
replies and may be confusing when testing packet loss rate by pinging
a rloc/aloc address.

Added OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY to otIcmp6EchoMode to let
OT only handle echo request to rloc/aloc addresses, this is the
default mode in posix code. Set otIcmp6EchoMode to
OT_ICMP6_ECHO_HANDLER_DISABLED will help to avoid double ping replies
from both OT and host.
sunytt authored Apr 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 59572efb4e51c9b0218e840bad8c6dc7758dc3a0
1 change: 1 addition & 0 deletions include/openthread/icmp6.h
Original file line number Diff line number Diff line change
@@ -144,6 +144,7 @@ typedef enum otIcmp6EchoMode
OT_ICMP6_ECHO_HANDLER_UNICAST_ONLY = 1, ///< ICMPv6 Echo processing enabled only for unicast requests only
OT_ICMP6_ECHO_HANDLER_MULTICAST_ONLY = 2, ///< ICMPv6 Echo processing enabled only for multicast requests only
OT_ICMP6_ECHO_HANDLER_ALL = 3, ///< ICMPv6 Echo processing enabled for unicast and multicast requests
OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY = 4, ///< ICMPv6 Echo processing enabled for RLOC/ALOC destinations only
} otIcmp6EchoMode;

/**
2 changes: 1 addition & 1 deletion include/openthread/instance.h
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ extern "C" {
* @note This number versions both OpenThread platform and user APIs.
*
*/
#define OPENTHREAD_API_VERSION (404)
#define OPENTHREAD_API_VERSION (405)

/**
* @addtogroup api-instance
6 changes: 4 additions & 2 deletions src/core/net/icmp6.cpp
Original file line number Diff line number Diff line change
@@ -171,6 +171,9 @@ bool Icmp::ShouldHandleEchoRequest(const MessageInfo &aMessageInfo)
case OT_ICMP6_ECHO_HANDLER_ALL:
rval = true;
break;
case OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY:
rval = aMessageInfo.GetSockAddr().GetIid().IsLocator();
break;
}

return rval;
@@ -184,8 +187,7 @@ Error Icmp::HandleEchoRequest(Message &aRequestMessage, const MessageInfo &aMess
MessageInfo replyMessageInfo;
uint16_t dataOffset;

// always handle Echo Request destined for RLOC or ALOC
VerifyOrExit(ShouldHandleEchoRequest(aMessageInfo) || aMessageInfo.GetSockAddr().GetIid().IsLocator());
VerifyOrExit(ShouldHandleEchoRequest(aMessageInfo));

LogInfo("Received Echo Request");

2 changes: 2 additions & 0 deletions src/lib/spinel/spinel.h
Original file line number Diff line number Diff line change
@@ -607,6 +607,7 @@ typedef enum
SPINEL_IPV6_ICMP_PING_OFFLOAD_UNICAST_ONLY = 1,
SPINEL_IPV6_ICMP_PING_OFFLOAD_MULTICAST_ONLY = 2,
SPINEL_IPV6_ICMP_PING_OFFLOAD_ALL = 3,
SPINEL_IPV6_ICMP_PING_OFFLOAD_RLOC_ALOC_ONLY = 4,
} spinel_ipv6_icmp_ping_offload_mode_t;

typedef enum
@@ -3457,6 +3458,7 @@ enum
* SPINEL_IPV6_ICMP_PING_OFFLOAD_UNICAST_ONLY = 1
* SPINEL_IPV6_ICMP_PING_OFFLOAD_MULTICAST_ONLY = 2
* SPINEL_IPV6_ICMP_PING_OFFLOAD_ALL = 3
* SPINEL_IPV6_ICMP_PING_OFFLOAD_RLOC_ALOC_ONLY = 4
*
* Default value is `NET_IPV6_ICMP_PING_OFFLOAD_DISABLED`.
*
2 changes: 1 addition & 1 deletion src/ncp/ncp_base.cpp
Original file line number Diff line number Diff line change
@@ -340,7 +340,7 @@ NcpBase::NcpBase(Instance *aInstance)
#if OPENTHREAD_CONFIG_UDP_FORWARD_ENABLE
otUdpForwardSetForwarder(mInstance, &NcpBase::HandleUdpForwardStream, this);
#endif
otIcmp6SetEchoMode(mInstance, OT_ICMP6_ECHO_HANDLER_DISABLED);
otIcmp6SetEchoMode(mInstance, OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY);
#if OPENTHREAD_FTD
otThreadRegisterNeighborTableCallback(mInstance, &NcpBase::HandleNeighborTableChanged);
#if OPENTHREAD_CONFIG_MLE_STEERING_DATA_SET_OOB_ENABLE
6 changes: 6 additions & 0 deletions src/ncp/ncp_base_mtd.cpp
Original file line number Diff line number Diff line change
@@ -2072,6 +2072,9 @@ template <> otError NcpBase::HandlePropertyGet<SPINEL_PROP_IPV6_ICMP_PING_OFFLOA
case OT_ICMP6_ECHO_HANDLER_ALL:
mode = SPINEL_IPV6_ICMP_PING_OFFLOAD_ALL;
break;
case OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY:
mode = SPINEL_IPV6_ICMP_PING_OFFLOAD_RLOC_ALOC_ONLY;
break;
};

return mEncoder.WriteUint8(mode);
@@ -2099,6 +2102,9 @@ template <> otError NcpBase::HandlePropertySet<SPINEL_PROP_IPV6_ICMP_PING_OFFLOA
case SPINEL_IPV6_ICMP_PING_OFFLOAD_ALL:
mode = OT_ICMP6_ECHO_HANDLER_ALL;
break;
case SPINEL_IPV6_ICMP_PING_OFFLOAD_RLOC_ALOC_ONLY:
mode = OT_ICMP6_ECHO_HANDLER_RLOC_ALOC_ONLY;
break;
};

otIcmp6SetEchoMode(mInstance, mode);