Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with #1530 #1592

Merged
merged 10 commits into from
Oct 29, 2017
Merged

Deal with #1530 #1592

merged 10 commits into from
Oct 29, 2017

Conversation

sergeyklay
Copy link
Contributor

No description provided.

@Jurigag
Copy link
Contributor

Jurigag commented Oct 28, 2017

Well tests are passing, you need to test it on TS php i think.

Failed travis are because of valgrind, not sure if related or not.

@sergeyklay
Copy link
Contributor Author

sergeyklay commented Oct 28, 2017 •
edited
Loading

In fact, I'm aware of the problem root. This PR just debug, not solution. And I have all of required ;)

$ ls -1 $(phpenv root)/versions/
5.5.38-nts-debug
5.6.31-nts-debug
5.6.31-zts-debug
7.0.25-nts-debug
7.0.25-zts-debug
7.1.11-nts-debug
7.1.11-zts-debug
system

@sergeyklay sergeyklay merged commit 075d4e9 into zephir-lang:development Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyklay @Jurigag