Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#120 - Add mixed type #121

Merged
merged 5 commits into from
Sep 15, 2021
Merged

#120 - Add mixed type #121

merged 5 commits into from
Sep 15, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Sep 15, 2021

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Thanks

@Jeckerson Jeckerson linked an issue Sep 15, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #121 (02173de) into development (3fee124) will increase coverage by 0.14%.
The diff coverage is 64.70%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #121      +/-   ##
===============================================
+ Coverage        75.18%   75.32%   +0.14%     
===============================================
  Files                5        5              
  Lines             2909     2926      +17     
===============================================
+ Hits              2187     2204      +17     
  Misses             722      722              
Flag Coverage Δ
unittests 75.32% <64.70%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
parser/zephir.lemon 47.56% <40.00%> (+0.49%) ⬆️
parser/parser.h 89.07% <50.00%> (-0.33%) ⬇️
parser/base.c 93.82% <100.00%> (+0.03%) ⬆️
parser/scanner.re 98.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fee124...02173de. Read the comment docs.

@Jeckerson Jeckerson marked this pull request as ready for review September 15, 2021 13:25
@Jeckerson Jeckerson merged commit 5605563 into development Sep 15, 2021
@Jeckerson Jeckerson deleted the #120-mixed-type branch September 15, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NFR] Add support for mixed return type (PHP >= 8.0)
2 participants