Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asserting json->decoded() on zeros #136

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix asserting json->decoded() on zeros #136

merged 1 commit into from
Nov 14, 2023

Conversation

norkunas
Copy link
Contributor

@norkunas norkunas commented Nov 14, 2023 •
edited
Loading

Not sure why this was made this way, so proposing this because my assertion does not work with a real world example from api-platform endpoint :)

Additionally fixed:

Since symfony/framework-bundle 6.1: Not setting the "framework.http_method_override" config option is deprecated. It will default to "false" in 7.0

kbond
kbond approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas!

@kbond kbond merged commit 7de7c02 into zenstruck:1.x Nov 14, 2023
@norkunas norkunas deleted the json-decoded branch November 14, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norkunas @kbond