fix: assign default value to field which uses auth() in @default when generating logical schema
#1962
Conversation
…when generating logical schema
📝 WalkthroughWalkthroughThe changes introduce a new private method Changes
Sequence DiagramsequenceDiagram
participant SchemaGenerator
participant ModelField
participant DataModelField
participant P as Pattern Matcher
SchemaGenerator->>ModelField: generateModelField()
alt Is logical mode with auth() default
SchemaGenerator->>SchemaGenerator: setDummyDefault()
SchemaGenerator->>P: Match field type
P-->>SchemaGenerator: Determine dummy value
SchemaGenerator->>ModelField: Set dummy default
end
The sequence diagram illustrates the flow of setting a dummy default value during schema generation, highlighting the interaction between the schema generator, model field, and pattern matching mechanism. Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/schema/src/plugins/prisma/schema-generator.ts (1)
883-898: Consider enhancing the implementation with these refinements.
- Add JSDoc documentation to explain the method's purpose and parameters
- Improve the error message to include the field name
- Optimize the pattern matching for numeric types
Here's a suggested implementation:
+ /** + * Sets a dummy default value for a field that uses auth() in @default + * @param result The ModelField to modify + * @param field The original DataModelField + */ private setDummyDefault(result: ModelField, field: DataModelField) { const dummyDefaultValue = match(field.type.type) .with('String', () => new AttributeArgValue('String', '')) - .with(P.union('Int', 'BigInt', 'Float', 'Decimal'), () => new AttributeArgValue('Number', '0')) + .with( + P.union('Int', 'BigInt', 'Float', 'Decimal'), + (type) => new AttributeArgValue('Number', '0') + ) .with('Boolean', () => new AttributeArgValue('Boolean', 'false')) .with('DateTime', () => new AttributeArgValue('FunctionCall', new PrismaFunctionCall('now'))) .with('Json', () => new AttributeArgValue('String', '{}')) .with('Bytes', () => new AttributeArgValue('String', '')) .otherwise(() => { - throw new PluginError(name, `Unsupported field type with default value: ${field.type.type}`); + throw new PluginError( + name, + `Field "${field.$container.name}.${field.name}" has unsupported type "${field.type.type}" for @default(auth())` + ); }); result.attributes.push( new PrismaFieldAttribute('@default', [new PrismaAttributeArg(undefined, dummyDefaultValue)]) ); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/schema/src/plugins/prisma/schema-generator.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: dependency-review
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: OSSAR-Scan
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
🔇 Additional comments (2)
packages/schema/src/plugins/prisma/schema-generator.ts (2)
872-879: LGTM! Clean implementation of logical mode handling.The conditional block correctly handles fields with
@default(auth())in logical mode by setting appropriate dummy default values.
883-898: LGTM! Well-structured pattern matching implementation.The method effectively handles all Prisma primitive types and sets appropriate dummy default values.
No description provided.