fix(delegate): fields from delegate models used in logical groups inside filter are not translated

[ymc9]

Fixes #1410

[coderabbitai]

Walkthrough

Walkthrough

The update introduces enhanced handling of logical operators in query conditions and adds a regression test for querying a data model with inheritance. This addresses issues with querying fields from a base model using logical operators like 'AND', 'OR', 'NOT'.

Changes

File Path	Change Summary
packages/runtime/.../delegate.ts	Added recursive handling for logical operators in where clauses of queries.
tests/regression/.../issue-1410.test.ts	New test for querying entities with conditions in a model using inheritance.

Assessment against linked issues

Objective	Addressed	Explanation
Allow querying base model fields in inherited models (#1410)	✅
Resolve errors in delegation setup and schema generation related to @@map() (#1167)	❌	The changes do not involve @@map() or schema generation issues.
Allow multiple fields to reference the same model without validation errors (#653)	❌	No changes related to multiple references or validation errors.
Address uniqueness constraint error in schema generation for polymorphic models (#1058)	❌	No modifications related to map properties or constraint names.

Possibly related issues

• Issue Delegating models can't use @@map() #1167: Although this issue involves delegation, the current PR does not address @@map() or schema generation errors, which are central to Delegating models can't use @@map() #1167.
• Issue Zenstack does not let me define multiple fields that are referencing the same model #653: This PR does not touch on multiple fields referencing the same model, hence it is not directly related to the objectives of Zenstack does not let me define multiple fields that are referencing the same model #653.
• Issue Error when generating from schema with polymorphic models - given constraint name ... has to be unique in the following namespace... #1058: The current changes do not deal with the uniqueness constraint issues specified in Error when generating from schema with polymorphic models - given constraint name ... has to be unique in the following namespace... #1058, focusing instead on logical operator handling in queries.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 153dd4f and 59db43e.

Files selected for processing (2)

• packages/runtime/src/enhancements/delegate.ts (1 hunks)
• tests/regression/tests/issue-1410.test.ts (1 hunks)

Files not reviewed due to errors (1)

• tests/regression/tests/issue-1410.test.ts (no review received)

Additional comments not posted (1)

packages/runtime/src/enhancements/delegate.ts (1)

102-106: The implementation of the recursive processing for logical groupings ('AND', 'OR', 'NOT') in the where object is correctly handled. This change ensures that fields from base models are recognized when used in these conditions, which is crucial for resolving the issue described in the PR.