Reference implementation #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a reference implementation for this. Code is linted with ESLint (w/ Airbnb rules), compiled with Babel (w/ "es2015" preset) and tested with Jest. (Tests are a bit weak, could be extended later.)
Doing this was easy since this spec doesn't define any new syntax. More work will be required if @domenic's
throw cancel / catch cancelis incorporated to this spec.Creating a reference implementation might look unnecessary at this time, but I really need this functionality in my projects. So instead of coming up with my own solution, I decided to implement this spec.
I will be using this in a few React components where I start an async task in
componentDidMount()which I have to cancel whencomponentWillReceiveProps()orcomponentWillUnmount()is called.