-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat adding es5 as target for webpack compilation #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderberto
reviewed
Mar 9, 2021
@@ -13,6 +13,7 @@ Licensed MIT © Zeno Rocha`; | |||
module.exports = { | |||
entry: './src/clipboard.js', | |||
mode: 'production', | |||
target: ['web', 'es5'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Did you try with ES5 build to validate the issue opened about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES-Check: there were no ES version matching errors! 🎉
helderberto
approved these changes
Mar 9, 2021
This was referenced Mar 11, 2021
Merged
This was referenced Mar 14, 2021
This was referenced Jun 6, 2021
Closed
1 task
1 task
This was referenced Jul 21, 2021
1 task
Closed
1 task
1 task
This was referenced Jan 14, 2022
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR should close #737 #738,
what happened was that once we update to use webpack5 the target option was not specified and the build was created with arrow functions, breaking the es5 builds, by targeting the build we can avoid that.
https://webpack.js.org/blog/2020-10-10-webpack-5-release/#improved-code-generation