Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating type definitions #736

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

vitormalencar
Copy link
Collaborator

@vitormalencar vitormalencar commented Mar 7, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

this PR should close the #735, in the new release we wanted to include type definitions for typescript making sure that everything is compatible with the previous version

@vitormalencar vitormalencar marked this pull request as ready for review March 8, 2021 10:44
@vitormalencar vitormalencar self-assigned this Mar 8, 2021
@vitormalencar vitormalencar linked an issue Mar 8, 2021 that may be closed by this pull request
Copy link
Collaborator

@helderberto helderberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS errors or breaking changes in 2.0.7
3 participants