landing page: add blr related works section #674

jennur · 2023-12-08T22:48:05Z

Closes https://github.com/zenodo/rdm-project/issues/567

Needs inveniosoftware/react-searchkit#260

Edit: After discussing with Lars, it was decided to remove the search bar for now, as there are issues related to having the initial query string (to show only related results for the specific record) + additional query strings added by the user. In order to add the search bar back, these are the known alternatives that will need a solution:

if the query string is added to the state (queryString), the string shows up in the input field. The input field should be empty, but the query string needs to remain.
if the query string is added directly to the endpoint url parameters, the search does not work, as there will be two q parameters once another search is performed.
the query string cannot be set as a filter, as this requires the implementation of custom filters in the backend.

Screenshots

assets/less/zenodo-rdm/globals/site.overrides

kpsherva · 2023-12-12T14:25:12Z

...zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/components/BlrSearchBar.js

+import { PropTypes } from "prop-types";
+import { Input, Icon } from "semantic-ui-react";
+
+export const BlrSearchBar = ({


is this component any different that the default search bar? maybe I am missing context but my first thought is this PR recreates the whole search app and duplicates a lot of code. We could possibly use overridable features like in other searches.
I don't see any major layout difference with other searches, but correct me if I am missing something

You're right, the search bar override is not needed I think. I think I can solve it with the props only. Thanks!

Do you mean the search app from invenio-search-ui? I'm overriding some ReactSearchKit components, but they would have to be overridden in any case, as the layout is not the same. I'm not sure I see the benefit of using invenio-search-ui here?

jrcastro2

LGTM!
Just left a minor comment about the filter, the PR also need to be rebased there are conflicts.

jrcastro2 · 2023-12-18T13:10:19Z

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/components/Filter.js

+
+export const Filter = ({ valuesCmp }) => {
+  return (
+    <Dropdown text="Filter by type" button>


Comment: By using the text prop, the user will not see what type of filter is selected unless (s)he opens the dropodwn. I find it more intuitive if once we have selected the filter it's value is displayed.

Suggested change

<Dropdown text="Filter by type" button>

<Dropdown placeholder="Filter by type" button>

Thanks! I do agree, although this dropdown is a bit different since it works like the filters on the regular search (with checkboxes), so multiple options can be checked.

Right! Good point! In that case I would just display some text mentioning how many filters are selected like "X filters selected" so that the user is aware that there are filters selected when the dropdown is closed. However this can be addressed in another issue, if we do so please create the issue!

Thanks! I will test it!

jennur · 2023-12-22T08:49:35Z

Update

Added counter for selected filters

ntarocco

If meant to be reusable, it should be moved to InvenioRDM (maybe later?) and naming should be changed to be more generic (BLR -> Linked records).

ntarocco · 2024-01-19T17:12:14Z

assets/less/zenodo-rdm/globals/site.overrides

@@ -138,4 +138,9 @@ a.inverted {
  .ui.medium.header {
    font-size: 1.45rem;
  }
+}
+
+.image.thumbnail-image {


Does this works well in mobile version?

Looks good!

ntarocco · 2024-01-19T17:14:07Z

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/BlrSearch.js

+
+  return (
+    <>
+      <Header as="h2">Linked records</Header>


Will Zenodo be available in multiple languages at some point? We might have to mark all strings as translatable.

As far as I remember, it was a problematic thing to implement... but anyway that would be another task to go around and make all the strings translatable, for now doing that would be useless

ntarocco · 2024-01-19T17:16:19Z

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/BlrSearch.js

+
+  return (
+    <>
+      <Header as="h2">Linked records</Header>


This could be maybe moved to Jinja (if easy) to avoid the page flickering.

slint

Looks good overall, some minor comments and/or things to shelve.

Sign-off: @carlinmack @slint

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/index.js

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/BlrSearch.js

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/components/RecordItem.js

site/zenodo_rdm/assets/semantic-ui/js/zenodo_rdm/src/blr-related-works/index.js

templates/semantic-ui/zenodo_rdm/records/detail.html

* search for related records only within BLR community * adjust empty search results to absence of search bar * add a new loader placeholder

jennur force-pushed the blr-related-works branch from 22c5a15 to 2ae3fd8 Compare December 11, 2023 20:28

kpsherva reviewed Dec 12, 2023

View reviewed changes

assets/less/zenodo-rdm/globals/site.overrides Show resolved Hide resolved

kpsherva reviewed Dec 12, 2023

View reviewed changes

jennur force-pushed the blr-related-works branch 3 times, most recently from dc0ea53 to d62d05f Compare December 13, 2023 16:27

jennur marked this pull request as ready for review December 13, 2023 16:38

jennur force-pushed the blr-related-works branch 5 times, most recently from 8325992 to 82d70a3 Compare December 13, 2023 17:33

jrcastro2 approved these changes Dec 18, 2023

View reviewed changes

jennur force-pushed the blr-related-works branch 2 times, most recently from 61893b9 to 4bb99cd Compare December 21, 2023 15:27

landing page: add blr related works section

23f1e3a

anikachurilova force-pushed the blr-related-works branch 6 times, most recently from 3986126 to d4d71c7 Compare January 19, 2024 15:52

ntarocco reviewed Jan 19, 2024

View reviewed changes

anikachurilova force-pushed the blr-related-works branch 3 times, most recently from b7605d7 to 736cfe4 Compare January 22, 2024 13:17

slint approved these changes Jan 23, 2024

View reviewed changes

slint mentioned this pull request Jan 24, 2024

links: missing thumbnail links on /api/records #682

Open

anikachurilova force-pushed the blr-related-works branch 3 times, most recently from a1ba60d to 86c460d Compare January 24, 2024 14:01

slint approved these changes Jan 24, 2024

View reviewed changes

blr: landing page fixes

12b810a

* search for related records only within BLR community * adjust empty search results to absence of search bar * add a new loader placeholder

anikachurilova force-pushed the blr-related-works branch from 86c460d to 12b810a Compare January 24, 2024 15:09

slint merged commit b5268aa into zenodo:master Jan 25, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

landing page: add blr related works section #674

landing page: add blr related works section #674

jennur commented Dec 8, 2023 •

edited

Loading

kpsherva Dec 12, 2023 •

edited

Loading

jennur Dec 12, 2023 •

edited

Loading

jrcastro2 left a comment

jrcastro2 Dec 18, 2023 •

edited

Loading

jennur Dec 20, 2023

jrcastro2 Dec 20, 2023

jennur Dec 21, 2023

jennur commented Dec 22, 2023

ntarocco left a comment •

edited

Loading

ntarocco Jan 19, 2024

anikachurilova Jan 22, 2024

ntarocco Jan 19, 2024

anikachurilova Jan 22, 2024

ntarocco Jan 19, 2024

slint left a comment

	<Dropdown text="Filter by type" button>
	<Dropdown placeholder="Filter by type" button>

landing page: add blr related works section #674

landing page: add blr related works section #674

Conversation

jennur commented Dec 8, 2023 • edited Loading

Screenshots

kpsherva Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

jennur Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

jrcastro2 left a comment

Choose a reason for hiding this comment

jrcastro2 Dec 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jennur commented Dec 22, 2023

Update

ntarocco left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slint left a comment

Choose a reason for hiding this comment

jennur commented Dec 8, 2023 •

edited

Loading

kpsherva Dec 12, 2023 •

edited

Loading

jennur Dec 12, 2023 •

edited

Loading

jrcastro2 Dec 18, 2023 •

edited

Loading

ntarocco left a comment •

edited

Loading