Add custom code for support

[zzacharo]

• address support form: integrate zenodo implementation #71

[alejandromumo]

react-dropzone has an input element that is hidden.

In other parts of invenio we keep it that way and re-implement it with either a button or a box for drag and drop. Here I went for a simpler solution, might not be the best though.

[alejandromumo]

This can be simplified into a method that works solely with contexts, as suggested by @slint personally.

I can tackle this in a separate task.

Same applies for the method send_confirmation_email

[alejandromumo]

Currently not in use. Can be used when Marshmallow fails to validate the form data or simply removed (marshmallow already throws a ValidationError) .

[alejandromumo]

Currently the only handler is to send two emails. However it can grow into different behaviors (e.g. based on a category do something else)

[alejandromumo]

I am unsure whether this error handling is ideal.

Please let me know if it can be improved.

[kpsherva]

should raise (not return) a rest error, there are defined already in flask resources

[alejandromumo]

Thanks! I realized 500 errors already have a default handler and we can work with that.

For ValidationError I added a custom handler. It returns an object similar to what we have in other modules, making the response serializable to formik. E.g.

{
  "errors": [
    {
      "field": "email",
      "messages": [
        "Not a valid email address."
      ]
    },
    {
      "field": "description",
      "messages": [
        "Description length must be bigger than 20 characters"
      ]
    }
  ]
}

[kpsherva]

can this styling be moved to theme files?

[kpsherva]

does it make sense to be moved to the constructor instead of redeclaring it on each render?

[kpsherva]

this will catch any exception and will make debugging harder, is it on purpose ?

[alejandromumo]

it emulates the original one https://github.com/zenodo/zenodo/blob/master/zenodo/modules/support/views.py#L68, with more granular error catching (e.g. not sending the support email is not the same as not sending the confirmation email).

I agree that we lose the message and it will a nightmare to debug, especially since it is working with e-mail. Is there a standard way of logging exceptions in invenio?

[kpsherva]

all the comments can be addressed in the second iteration if that is easier to manage