Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moderation: added query match rule #1049

Merged
merged 2 commits into from
Nov 11, 2024
Merged

moderation: added query match rule #1049

merged 2 commits into from
Nov 11, 2024

Conversation

0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Nov 6, 2024 •
edited
Loading

Closes Issue #1042

cli commands

Create percolator moderation index for records

invenio moderation create-queries-index -r records

Add a query

Defaults to score 10 and active True if not provided

invenio moderation add-query --query-strinf "metadata.title:Spam" --notes "New query" --score 13 --active True

Add queries from csv

Defaults to score 10 and active True if not provided
csv format

query_string1, notes, score, active
query_string2, notes, score, active

invenio moderation add-query -f .../queries.csv

@0einstein0 0einstein0 linked an issue Nov 6, 2024 that may be closed by this pull request
Store queries in DB table and index as OpenSearch percolators to allow for reverse lookup #1042
Closed
@0einstein0 0einstein0 force-pushed the moderation-rules branch 4 times, most recently from 5ef0e19 to 857502d Compare November 7, 2024 09:00
@0einstein0 0einstein0 force-pushed the moderation-rules branch 2 times, most recently from e4a30b7 to 9b9e167 Compare November 8, 2024 08:17
slint
slint reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, but otherwise LGTM

site/zenodo_rdm/moderation/percolator.py Outdated Show resolved Hide resolved
site/zenodo_rdm/moderation/percolator.py Show resolved Hide resolved
site/zenodo_rdm/moderation/percolator.py Outdated Show resolved Hide resolved
site/zenodo_rdm/moderation/rules.py Outdated Show resolved Hide resolved
site/tests/moderation/test_moderation_queries.py Show resolved Hide resolved
@0einstein0 0einstein0 force-pushed the moderation-rules branch 5 times, most recently from d72dadb to a39f1e1 Compare November 8, 2024 12:59
@slint slint mentioned this pull request Nov 11, 2024
Open
@slint slint merged commit 6210c61 into zenodo:master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store queries in DB table and index as OpenSearch percolators to allow for reverse lookup
2 participants
@0einstein0 @slint