Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant install v1.0.0-beta-2 or beta-3 from npm #166

Closed
LeoIannacone opened this issue Feb 28, 2017 · 14 comments
Closed

Cant install v1.0.0-beta-2 or beta-3 from npm #166

LeoIannacone opened this issue Feb 28, 2017 · 14 comments

Comments

@LeoIannacone
Copy link

Hi,

npm install does not work with v1.0.0-beta-2

@eliwinkelman
Copy link

I think the current version is beta-1
npm install [email protected] worked for me

@alexkrolick
Copy link
Collaborator

beta-2 is not on NPM yet. You can point package.json at react-quill: zenoamaro/[email protected] if you want, but unless you are affected by the bugs that have recently been fixed, you can wait for the NPM module to be updated.

cc @zenoamaro

@alexkrolick alexkrolick reopened this Mar 1, 2017
@alexkrolick alexkrolick changed the title Cant install v1.0.0 Cant install v1.0.0-beta-2 from npm Mar 1, 2017
@LeoIannacone
Copy link
Author

Due to your .npmignore I can't install from github (the directory will be ready)

@alexkrolick
Copy link
Collaborator

alexkrolick commented Mar 1, 2017 via email

@alexkrolick
Copy link
Collaborator

npm install https://github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz
{
   "react-quill": "https://github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz"
}

@yfilali
Copy link

yfilali commented Mar 7, 2017

@alexkrolick The tarballs for beta-2 and beta-3 have empty dist folders (at least as far as I can see on OSX)

Without at least beta-2, Quill isn't exposed and the examples for custom formats don't work at the moment.

The error when installing from tar:

> npm install https://github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz

npm ERR! tar.unpack untar error /var/folders/9v/b9tfdnx93hd62q4_6k_yg5x00000gn/T/npm-6895-0af5a01d/github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz
npm ERR! tar.unpack untar error /var/folders/9v/b9tfdnx93hd62q4_6k_yg5x00000gn/T/npm-6895-0af5a01d/github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz
npm ERR! tar.unpack untar error /var/folders/9v/b9tfdnx93hd62q4_6k_yg5x00000gn/T/npm-6895-0af5a01d/github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz
npm ERR! Darwin 16.4.0
npm ERR! argv "/Users/yacine/.nvm/versions/node/v6.9.5/bin/node" "/Users/yacine/.nvm/versions/node/v6.9.5/bin/npm" "install" "https://github.com/zenoamaro/react-quill/releases/download/v1.0.0-beta-2/react-quill-v1.0.0-beta-2.tgz"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10

npm ERR! invalid tar file

@alexkrolick
Copy link
Collaborator

Thanks for reporting. Looks like a Yarn bug: yarnpkg/yarn#2851

Fell back to npm pack and uploaded a new one for beta-3. https://github.com/zenoamaro/react-quill/releases/tag/v1.0.0-beta-3

@yfilali
Copy link

yfilali commented Mar 7, 2017

Worked like a charm. Thanks for the quick fix!

@yfilali
Copy link

yfilali commented Mar 7, 2017

Ooh, I thought we had it , but I now get a module not found (which I think is because the entry file src/index.js is missing due to /src being in .npmignore and files: [...] missing 'src/' in package.json)

Module not found: Error: Cannot resolve module 'react-quill'

@alexkrolick
Copy link
Collaborator

Does it work if you change the entry in package.json in your node_modules/react-quill to "main": "dist/react-quill.min.js"

If so I'll push that

@yfilali
Copy link

yfilali commented Mar 7, 2017

Yes, that works. Everything is loading properly including the Quill export and the styles.

@alexkrolick
Copy link
Collaborator

OK, updated the release and tag.

@yfilali
Copy link

yfilali commented Mar 7, 2017

New tar ball is working properly now, I cleaned up and reinstalled from scratch and re-tested:

rm -rf node_modules && npm cache clean && npm install

@alexkrolick alexkrolick changed the title Cant install v1.0.0-beta-2 from npm Cant install v1.0.0-beta-2 or beta-3 from npm Mar 8, 2017
@alexkrolick
Copy link
Collaborator

The betas should now be available on NPM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants