Add shave config to editor, and update all color pickers #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to solve for #43 |
dumbmatter
requested changes
May 15, 2024
There was a problem hiding this comment.
Thanks, just a few review comments, this mostly looks good!
Should there be default swatches in the ColorPicker?
I think what you did (using the gallery feature colors) was a good idea.
I disabled alpha values for everything but Head Face Shave. Seems like the right thing to do, but some people might like making a transparent person for fun?
Also agree with what you did here.
dumbmatter
reviewed
May 15, 2024
| @@ -255,28 +258,36 @@ const FeatureSelector = ({ | |||
| // @ts-expect-error TS doesnt like conditional array vs string | |||
| hasMultipleColors ? selectedVal[colorIndex] : selectedVal; | |||
|
|
|||
| let presetColors = hasMultipleColors | |||
| ? gallerySectionConfig.renderOptions.valuesToRender.map( | |||
| (colorList: string[]) => colorList[colorIndex], | |||
There was a problem hiding this comment.
I'll fix this when I merge in a minute, but there's no need for this type annotation, TypeScript already knows it's string[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds face shave as a configurable option in the editor, and changes all color pickers on the editor to resemble other newly updated ZenGM color pickers (with components stolen from other repo :D )
Items for thought: