This repository has been archived by the owner on May 16, 2018. It is now read-only.
Pass raw headers from imap storage as "raw" when creating a message #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes related to ZF2015-04, some messages that are read from imap throw an "Invalid header value detected" exception.
Zend_Mail_Storage_Imap::getMessage()
instantiates a newZend_Mail_Message
with an array of parameters. When these parameters contain the keyraw
, all occurrences of\n
not preceded with\r
are replaced with\r\n
in its value.Next
Zend_Mail_Part
will useZend_Mime_Decode::splitMessage
to turn the string into an array of headers, which is later validated.But:
Zend_Mail_Storage_Imap::getMessage()
doesn't use the keyraw
, but usesheaders
in stead. In this case the replace of\n
to\r\n
doesn't happen. The result is that headers like these will throw the "Invalid header value detected" exception:The
\n
will be seen as invalid.Fix:
This PR fixes this issue by using
raw
in stead ofheaders
.