Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Fix hostname subdomain underscore #232

Merged

Conversation

bacinsky
Copy link
Contributor

@bacinsky bacinsky commented Jun 7, 2018

Allowing underscore in hostname subdomains.

@bacinsky bacinsky force-pushed the fix/hostname-subdomain-underscore branch 2 times, most recently from 9bafe38 to 9193c9c Compare June 7, 2018 12:30
@weierophinney weierophinney added this to the 2.10.3 milestone Dec 13, 2018
@weierophinney weierophinney force-pushed the fix/hostname-subdomain-underscore branch from 9193c9c to f4c26cf Compare December 13, 2018 16:43
@weierophinney weierophinney changed the base branch from develop to master December 13, 2018 16:44
Renames `testUnderscore` to `testValidatorHandlesUnderscoresInDomainsCorrectly()`,
and has it use a data provider with individual inputs and assertions.
@weierophinney weierophinney merged commit b594e03 into zendframework:master Dec 13, 2018
@weierophinney
Copy link
Member

Thanks, @bacinsky

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants