This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Added Explode validator documentation #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
suggested changes
Dec 6, 2017
doc/book/validators/explode.md
Outdated
|
|
||
| The following options are supported for `Zend\Validator\Explode`: | ||
|
|
||
| - `valueDelimiter`: Defines the delimiter used to explode the value to an array. It defaults to `,`. If working with an array, this option isn't used. |
There was a problem hiding this comment.
If working with an array, this option isn't used.
We should clarify that the given "value" is meant here.
doc/book/validators/explode.md
Outdated
| ]); | ||
|
|
||
| $value = [1, 4, 6, 8]; | ||
| $return = $valid->isValid($value); |
There was a problem hiding this comment.
$valid is wrong here.
I would change the example:
$explodeValidator->isValid([1, 4, 6]); // returns true
$explodeValidator->isValid([1, 4, 6, 8]); // returns false
doc/book/validators/explode.md
Outdated
|
|
||
| $value = [1, 4, 6, 8]; | ||
| $return = $valid->isValid($value); | ||
| // returns false |
doc/book/validators/explode.md
Outdated
| // returns false | ||
| ``` | ||
|
|
||
| The above example returns `true` if all $value items are between 1 and 6. |
There was a problem hiding this comment.
Can be deleted, because is covered now in the example.
There was a problem hiding this comment.
Please add another example which demonstrate the usage of valueDelimiter. Thanks!
Improved valueDelimiter description. Fixed array example Added explode string example.
|
Hi @froschdesign , I added the valueDelimiter example and improved the valueDelimiter description. I also appreciated your suggestions and incorporated them into the chapter. |
weierophinney
added a commit
that referenced
this pull request
Feb 1, 2018
Added Explode validator documentation
weierophinney
added a commit
that referenced
this pull request
Feb 1, 2018
|
Thanks, @renanlibrato! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wrote the basic documentation for Explode validator.
It came useful for me lately so I'd like to contribute with it.
It fixes both #171 and #137 , which are duplicates.