This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
ValidatorManager as alias instead of factory identifier #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orManager` as alias for it
boesing
force-pushed
the
validator-plugin-manager-factory
branch
from
d0e13af to
d67f2d4
Compare
weierophinney
added a commit
that referenced
this pull request
Aug 14, 2017
ValidatorManager as alias instead of factory identifier
weierophinney
added a commit
that referenced
this pull request
Aug 14, 2017
weierophinney
added a commit
that referenced
this pull request
Aug 14, 2017
|
Thanks, @boesing. Merged to develop for release with 2.10.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I like the usage of
ValidatorPluginManager::classnotation, I would prefer if services like theValidatorManagerwill be able to get fetched by usingValidatorPluginManager::classaswell.Is there any reason why we wont provide such ability?