This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Changes done for adding support for "ø" for DK idn #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is due to zendframework/zend-servicemanager#182, not this PR. |
akrabat
approved these changes
Feb 24, 2017
|
Are there any other characters that should be allowed in a DK url? |
|
@akrabat , I am not sure for the other characters, I just came across the use case for this character and hence created this PR for the same. Thanks, |
|
@akrabat , I have added two more characters and updated the PR, Thanks, |
Xerkus
force-pushed
the
bugfix/support-for-ø-in-dk
branch
from
5520a29 to
0c4c3df
Compare
Xerkus
added a commit
that referenced
this pull request
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ever I try to create
Uriobject for url string "http://www.fitnessø.dk/", it throws an exception with message "Host "www.fitnessø.dk" is not valid or is not accepted by...". And when debugged the source, I came to know that this error is because it is not validated by HostName validator inUri::isValidDnsHostname().