Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Update Code128.php #105

Merged
merged 2 commits into from
May 17, 2017
Merged

Update Code128.php #105

merged 2 commits into from
May 17, 2017

Conversation

FraGoTe
Copy link
Contributor

@FraGoTe FraGoTe commented Jul 18, 2016

Avoiding warning in the last character zendframework/zend-barcode#28

@Xerkus
Copy link
Member

Xerkus commented Mar 17, 2017

i will keep this open for now. May be this issue should be addressed in zend-stdlib
zendframework/zend-stdlib#73

@weierophinney weierophinney merged commit 5551b3d into zendframework:master May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
@weierophinney
Copy link
Member

Thanks, @FraGoTe

@weierophinney
Copy link
Member

Actually, I need to revert this.

It causes the testCODE128() case to enter an infinite loop.

weierophinney added a commit that referenced this pull request May 17, 2017
This reverts commit 1fbb4fd, reversing
changes made to 95c9386.

The revert was performed as it introduced an infinite loop in the
`BarcodeTest::testCODE128()` test case.

Conflicts:
	src/Barcode/Code128.php
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants