This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Zend\Math is required by Zend\Validator\Csrf but packae is not required #147
Comments
|
All validators are opt -in, and the majority have no dependencies outside those in the "require" section. For this reason, we list any validator-specific deps as suggestions, but do not require them. Eventually, we may split these into separate packages so we can make those deps requirements, but for now, they are suggestions. |
|
Then the suggestions should at least include which validators can only be used when the suggested package is added… |
|
Would you be willing to do a PR for that, or at least start one?
…On Feb 18, 2017 8:21 AM, "Andreas Heigl" ***@***.***> wrote:
Then the suggestions should at least include which validators can only be
used when the suggested package is added…
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#147 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABlVzuWxutgn8bTXiligwIcUekj8PW5ks5rdv5agaJpZM4MFByw>
.
|
|
Already at it 😉 |
heiglandreas
added a commit
to heiglandreas/zend-validator
that referenced
this issue
Feb 18, 2017
This commit adds more infos why separate packages are suggested. This is especially of interest as different Validators are only usable with additional packages. This addresses zendframework#147
Ocramius
added a commit
that referenced
this issue
Feb 18, 2017
Ocramius
pushed a commit
that referenced
this issue
Feb 18, 2017
This commit adds more infos why separate packages are suggested. This is especially of interest as different Validators are only usable with additional packages. This addresses #147
Ocramius
added a commit
that referenced
this issue
Feb 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Zend\Validator\Csrfrequires the packageszend-sessionandzend-mathbut in composer.json they are only set as dev-requirements. Even though they are listed as suggestions, the package in itself is not usable without these packages. so they should be included in therequire-section.The text was updated successfully, but these errors were encountered: