Merge pull request #241 from andreasschroth/andreasschroth_fix_issue_240

Skip further checks in case of empty domain part
zendframework · Dec 13, 2018 · d8d06c2 · d8d06c2
2 parents fdaedea + 081fd6b
commit d8d06c2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Hostname.php b/src/Hostname.php
@@ -2092,6 +2092,13 @@ public function isValid($value)
                             }
                         }
 
+                        // Skip following checks if domain part is empty, as it definitely is not a valid hostname then
+                        if ($domainPart === '') {
+                            $this->error(self::INVALID_HOSTNAME);
+                            $status = false;
+                            break 2;
+                        }
+
                         // Check dash (-) does not start, end or appear in 3rd and 4th positions
                         if ($utf8StrWrapper->strpos($domainPart, '-') === 0
                             || ($utf8StrWrapper->strlen($domainPart) > 2

diff --git a/test/HostnameTest.php b/test/HostnameTest.php
@@ -701,4 +701,10 @@ public function testValidBizHostname()
         $validator = new Hostname();
         $this->assertTrue($validator->isValid('google.biz'));
     }
+
+    public function testHostnameWithEmptyDomainPart()
+    {
+        $validator = new Hostname();
+        $this->assertFalse($validator->isValid('.com'));
+    }
 }