Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Support PHP 7.2 #23

Closed
wants to merge 3 commits into from
Closed

Support PHP 7.2 #23

wants to merge 3 commits into from

Conversation

amcsi
Copy link
Contributor

@amcsi amcsi commented Apr 27, 2018

Starting with a .travis.yml file change to see what doesn't work.

@amcsi
Copy link
Contributor Author

amcsi commented Apr 27, 2018

@weierophinney There are failures (only for lowest dependencies) because of a deprecation in zend-validator:

1) ZendTest\Uri\MailtoTest::testInvalidMailtoUris with data set #2 ('mailto:[email protected]/bar/baz')
idn_to_utf8(): INTL_IDNA_VARIANT_2003 is deprecated
/home/travis/build/zendframework/zend-uri/vendor/zendframework/zend-validator/src/EmailAddress.php:545
/home/travis/build/zendframework/zend-uri/vendor/zendframework/zend-validator/src/EmailAddress.php:494
/home/travis/build/zendframework/zend-uri/src/Mailto.php:54
/home/travis/build/zendframework/zend-uri/test/MailtoTest.php:157

Are deprecation warnings acceptable for lowest dependencies?
Otherwise probably the minimal dependency that introduces the fix to this deprecation (if intl is loaded) is in zend-validator 2.10.2: zendframework/zend-validator@010084d

@weierophinney
Copy link
Member

In this case, bump the minimum supported version of zend-validator as part of the patch; that's essentially what is necessary to make this component work under 7.2.

Thanks!

@amcsi
Copy link
Contributor Author

amcsi commented Apr 27, 2018

@weierophinney I tried 2.10.1 which is one version lower than I anticipated, and it passes there for lowest.
I'm going to investigate to see which is truly the earliest good version.

By the way this tests pass for the current lowest (2.5.0) if the intl extension is not loaded. Apparently the iffy behavior actually starts happening once the intl extension is enabled.

@amcsi
Copy link
Contributor Author

amcsi commented Apr 27, 2018

@amcsi
Copy link
Contributor Author

amcsi commented Apr 27, 2018

I've generated the composer.lock file by removing vendor and composer.lock and doing composer install --ignore-platform-reqs

weierophinney added a commit that referenced this pull request Apr 30, 2018
weierophinney added a commit that referenced this pull request Apr 30, 2018
Forward port #25
Forward port #23

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Thanks, @amcsi !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants