Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

PHPUnit update #42

Closed
wants to merge 11 commits into from
Closed

PHPUnit update #42

wants to merge 11 commits into from

Conversation

kokspflanze
Copy link
Contributor

  • PHPUnit_Framework_TestCase migration to namespaces
  • drop php5.5
  • update phpunit version
  • setExpectedException updated to expectException
  • changed getMock to getMockBuilder
  • fix assertions errors
  • removed ServerTest::testSetObjectThrowsExceptionWithBadInput3, no tests there
  • travis updated with lowest/locked and latest test
  • drop hhvm/php 5.5 from build matrix and added php 7.1

kokspflanze and others added 7 commits June 5, 2017 20:55
@kokspflanze
PHPUnit_Framework_TestCase migration to namespaces
b5bd0f3
@kokspflanze
drop php5.5
3d62433 
update phpunit version
@kokspflanze
setExpectedException updated to expectException
a00121b
@kokspflanze
changed getMock to getMockBuilder
784aa21
@kokspflanze
fix assertions errors
9d10346 
removed ServerTest::testSetObjectThrowsExceptionWithBadInput3, no tests there
@kokspflanze
travis updated with lowest/locked and latest test
3e6d68f 
drop hhvm/php 5.5 from build matrix and added php 7.1
@kokspflanze
Delete composer.phar
664b56b 
remove composer.phar
froschdesign
froschdesign suggested changes Aug 23, 2017
View reviewed changes
composer.json Outdated
@@ -13,15 +13,15 @@
}
},
"require": {
"php": "^5.5 || ^7.0",
"php": "^7.0 || ^5.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: "^5.6 || ^7.0" ("lowest || highest")

Reference:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to know, last time i had to change it to highest || lowest

composer.json Outdated
"zendframework/zend-server": "^2.6.1",
"zendframework/zend-stdlib": "^2.7 || ^3.0",
"zendframework/zend-uri": "^2.5.2"
},
"require-dev": {
"zendframework/zend-config": "^2.6",
"zendframework/zend-http": "^2.5.4",
"phpunit/PHPUnit": "^4.8",
"phpunit/PHPUnit": "^6.2.1 || ^5.7.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@froschdesign
Copy link
Member

A template for .travis.yml can be found here: https://github.com/zendframework/maintainers/blob/master/template/.travis.yml

@kokspflanze
Copy link
Contributor Author

@froschdesign travis.yml should be the same now, expected the php5.6 and 7 tests

michalbundyra
michalbundyra suggested changes Aug 24, 2017
View reviewed changes
composer.json Outdated
"zendframework/zend-server": "^2.6.1",
"zendframework/zend-stdlib": "^2.7 || ^3.0",
"zendframework/zend-uri": "^2.5.2"
},
"require-dev": {
"zendframework/zend-config": "^2.6",
"zendframework/zend-http": "^2.5.4",
"phpunit/PHPUnit": "^4.8",
"phpunit/PHPUnit": "^5.7.15 || ^6.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use here the latest version: ^5.7.21 || ^6.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr is some months ago, there was this uptodate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yeh, you've just changed yday to lowest || highest, sorry.

.travis.yml
- GH_REF: github.com/zendframework/zend-soap.git
- secure: "O2ECNTc7cif3sN3Iyjiheu4UsHcs4g/TrNtc5XqcTpecxcM4ncG1oLAoF62ZN2cwdpJ8nBwl3BQDI9nkLS+nxPHxdqV5bobZ/8ZcI1/2by+l9N720WQfezPxxSxAAPl5b1SXxocsWUiykJJpADqGdYjgfmgAyiK70tXN4XwZl27Svnh+ulqFB2aYQNUv28jJZ3/Pt8jW5sgTVYKYZ65bYirEHGMsUnOK5nJ/W04qoq1d8Qj5x4xTrA71KecibljXpqXHtrQRBpGoKmU8N0w7XdGn0l6xojEJ3QkLE1/1SrZq0r4GHgP294358IsepdQXoqAIxULR0nlNkLmDY//wQI6WRWOpTI+eYN+unoq/zDgPnZGzV6NX/BrRt1yxhNij8CpIvR8cg4WP52Cl2djG5YWr5sOOqffIvSDKJLZgUOb512F7DdI2Pr6HSDyOSqrKoMGMpLJb7/1sEumLfVGmpu9fgpWakxR5wTa0oMBZknyJVy18nj+mj5YgIzD+1FYzYj5ttajh3KKaxDgTCYHJkCA/MRONsr/Ap1oHI2W5iDgAEyaJhru0XefNjW37n/sx3QqZ+F4VZDbuTy8FaFMbnT6+brbCLdrxtmIwo2OhYob+G5rWQejnF81g1ShUE/H3l/rlQ+BLZzwYEgAHkJ5YTAQYq37E3Ra7DgOv14Ayjvo="
- COMPOSER_ARGS="--no-interaction"
- COVERAGE_DEPS="satooshi/php-coveralls"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need here also legacy dependencies. Library still support PHP 5.6 and PHP 7 so it is possible to have PHPUnit 5 or 6 depends on PHP version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the older prs are okay, than i change all other prs. atm its bit strange to create a pr and 2 or 3 or 4 months later something changed and i have to update all once. this take a bit time.

also that lock file is generate with php5.6 so its not needed, have to change everything but i want a confirmation of the old prs like zendframework/zend-stdlib#74

@kokspflanze
Copy link
Contributor Author

travis error The command "phpenv global 7.1" failed and exited with 1 during . =(

@weierophinney weierophinney mentioned this pull request Jan 29, 2018
Merged
weierophinney added a commit that referenced this pull request Jan 29, 2018
@weierophinney
Adds CHANGELOG entries for #42
940cafe 
Additionally, indicates next version will be 2.7.0.
weierophinney added a commit that referenced this pull request Jan 29, 2018
@weierophinney
Merge branch 'hotfix/qa-tools' into develop
f82660a 
Forward port #48
Forward port #32
Forward port #35
Forward port #41
Forward port #42

Conflicts:
	CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalbundyra michalbundyra michalbundyra requested changes

@froschdesign froschdesign froschdesign requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kokspflanze @froschdesign @michalbundyra