-
Notifications
You must be signed in to change notification settings - Fork 42
Add support for new SoapClient option: keep_alive and ssl_method #1
Conversation
*/ | ||
public function testAllSslMethodsAreSupported() | ||
{ | ||
if (!version_compare(PHP_VERSION, '5.5.0', '>=')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this. ZF > 2.5 has a minimum of php 5.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maks3w Done. I didn't know that master is already for 2.5, thanks!
I just accidentally discovered that tests failed in HHVM with this PR. I have to look into that. |
define the constants if not defined.
|
Please rebase your PR. There are merge conflicts. |
@Maks3w: Rebased and updated my code to short array syntax. Where should I define these constants? They need to be in global namespace. |
If constant is not preffixed with Anyway I think the feature of validate sslMethod can be omitted |
Ok, I completely removed the SSL method validation. There are other failures in HHVM, but those were already there. I could take a look at them later. |
Add support for new SoapClient option: keep_alive and ssl_method
Merged to develop for release with 2.6.0. |
Thank you 👍 And thank you @Maks3w for your code review |
This PR adds two
SoapClient
options introduced in PHP 5.4 and 5.5:keep_alive
option allows sending "Connection: close" header directly from SoapClient.ssl_method
option allows to specify the SSL version to use