Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add PHP 7.1 & 7.2 support, drop PHP 5.5 & HHVM, add PHPUnit 6 support #78

Merged
merged 58 commits into from
Jun 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
db77b8b
Bumped version
weierophinney Jul 5, 2016
60a55ba
Remove fast_finish flag
Koopzington Sep 15, 2016
be7996d
Fix the configuration key in the documentation from 'session' to 'ses…
MatthiasKuehneEllerhold Oct 5, 2016
8a07228
Remove CS dependencies and add zend-coding-standard to require-dev
Koopzington Nov 13, 2016
9663e83
Delete .php_cs
Koopzington Nov 13, 2016
7bde5a6
add/update phpcs.xml
Koopzington Nov 13, 2016
6643f7f
add/update composer scripts
Koopzington Nov 13, 2016
36ef0d0
Use composer scripts in .travis.yml
Koopzington Nov 13, 2016
793312e
Replace mentions of php-cs-fixer with phpcs
Koopzington Nov 13, 2016
d3e1b5e
Replace mentions of phpcs and phpcbf with composer scripts
Koopzington Nov 15, 2016
bc52b25
Destroy should only return false when removal of session truely fails.
rarog Nov 18, 2016
514c91d
Automated CS fixes
Koopzington Nov 19, 2016
b37b4fd
CS fixes
Koopzington Nov 19, 2016
0633929
Tests for: Destroy should only return false when removal of session t…
rarog Feb 8, 2017
d1e42ae
Correcting the used classes.
rarog Feb 8, 2017
c4bf1af
Defining behaviour of the test.
rarog Feb 8, 2017
5d976e5
Mocking additional argument.
rarog Feb 8, 2017
91167c5
Trying callback function.
rarog Feb 8, 2017
16b9640
Last try for today.
rarog Feb 8, 2017
067b30d
Enable Travis CI slack notifications
geerteltink Mar 29, 2017
a9169a6
SessionManager creates instance of $requestedName
May 1, 2017
f8a6aa4
Travis: test against 7.1 and nightly
Slamdunk Jun 9, 2017
e5e41c9
Distinct PHP 5.6+7.0 from PHP 7.1 exclusive session.* functionality
Slamdunk Jun 9, 2017
67cdd25
Added missing optionsProvider data set
Slamdunk Jun 9, 2017
81f1d39
Travis already do a composer self-update
Slamdunk Jun 9, 2017
a781ba0
Fix PHP 7.2 fatal error
Slamdunk Jun 9, 2017
a136d97
Travis: remove duplicated envs
Slamdunk Jun 9, 2017
572c784
Drop HHVM support
Slamdunk Jun 9, 2017
182874f
Drop PHP 5.5 support
Slamdunk Jun 9, 2017
4ebc512
Support PHPUnit 6
Slamdunk Jun 9, 2017
0cd9f36
Travis install: can't ignore platform requirements
Slamdunk Jun 9, 2017
cf7cac4
SessionManagerTest: use lambda function to test validator valid callable
Slamdunk Jun 9, 2017
e44fe47
Fixed PHPUnit compatibility from 5.7 to 6.1
Slamdunk Jun 9, 2017
d691509
Merge pull request #56 from Koopzington/remove-fast-finish
weierophinney Jun 19, 2017
646e90e
Merge pull request #65 from Koopzington/new-coding-standard
weierophinney Jun 19, 2017
58e4a48
Merge pull request #72 from xtreamwayz/hotfix/slack-notifications
weierophinney Jun 19, 2017
533cbfa
Merge branch 'hotfix/qa-tools'
weierophinney Jun 19, 2017
c29315c
Merge branch 'hotfix/qa-tools' into develop
weierophinney Jun 19, 2017
4454c9b
Merge pull request #61 from MatthiasKuehneEllerhold/docs_fix_config_key
weierophinney Jun 19, 2017
3b61495
Merge branch 'hotfix/61'
weierophinney Jun 19, 2017
bfaa483
Merge branch 'hotfix/61' into develop
weierophinney Jun 19, 2017
f659c37
Merge pull request #66 from rarog/master
weierophinney Jun 19, 2017
f7eac66
Updated test prophecy to return by reference
weierophinney Jun 19, 2017
d6eb001
Added CHANGELOG for #66
weierophinney Jun 19, 2017
6424dc6
Merge branch 'hotfix/66' into develop
weierophinney Jun 19, 2017
107877c
Merge branch 'hotfix/66'
weierophinney Jun 19, 2017
7f1cd49
Fix signature issue with AbstractContainer::offsetGet
weierophinney Jun 14, 2017
1c53fb4
Fix failing SessionConfig tests on PHP 7.1+
weierophinney Jun 14, 2017
3f515bc
Test against PHP 7.1 on Travis
weierophinney Jun 14, 2017
54f647b
Added CHANGELOG for #79
weierophinney Jun 19, 2017
55b6619
Merge branch 'hotfix/signatures' into develop
weierophinney Jun 19, 2017
5298c23
Merge pull request #73 from thomascube/master
weierophinney Jun 19, 2017
ee8b2e2
Minor updates to "$requestedName as SessionManager" feature
weierophinney Jun 19, 2017
2ca9774
Added CHANGELOG for #73
weierophinney Jun 19, 2017
27c07bb
Merge branch 'feature/73' into develop
weierophinney Jun 19, 2017
e7804f2
Merge pull request #78 from Slamdunk/develop_72
weierophinney Jun 19, 2017
39d491a
Improved build matrix
weierophinney Jun 19, 2017
f78e9b7
Updated new exception expectation to use `expectException()`
weierophinney Jun 19, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ vendor/
zf-mkdoc-theme/

clover.xml
composer.lock
coveralls-upload.json
phpunit.xml
45 changes: 0 additions & 45 deletions .php_cs

This file was deleted.

89 changes: 52 additions & 37 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ cache:

env:
global:
- COMPOSER_ARGS="--no-interaction"
- COVERAGE_DEPS="satooshi/php-coveralls"
- LEGACY_DEPS="phpunit/phpunit"
- SITE_URL: https://zendframework.github.io/zend-session
- GH_USER_NAME: "Matthew Weier O'Phinney"
- GH_USER_EMAIL: [email protected]
Expand All @@ -25,67 +28,79 @@ services:
- mongodb

matrix:
fast_finish: true
include:
- php: 5.5
env:
- EXECUTE_CS_CHECK=true
- php: 5.5
env:
- EVENT_MANAGER_VERSION="^2.6.2"
- SERVICE_MANAGER_VERSION="^2.7.5"
- php: 5.6
env:
- EXECUTE_TEST_COVERALLS=true
- DEPLOY_DOCS="$(if [[ $TRAVIS_BRANCH == 'master' && $TRAVIS_PULL_REQUEST == 'false' ]]; then echo -n 'true' ; else echo -n 'false' ; fi)"
- PATH="$HOME/.local/bin:$PATH"
- DEPS=lowest
- php: 5.6
env:
- EXECUTE_TEST_COVERALLS=true
- DEPS=locked
- TEST_COVERAGE=true
- DEPLOY_DOCS="$(if [[ $TRAVIS_BRANCH == 'master' && $TRAVIS_PULL_REQUEST == 'false' ]]; then echo -n 'true' ; else echo -n 'false' ; fi)"
- PATH="$HOME/.local/bin:$PATH"
- php: 5.6
env:
- EVENT_MANAGER_VERSION="^2.6.2"
- SERVICE_MANAGER_VERSION="^2.7.5"
- DEPS=latest
- php: 7
env:
- DEPS=lowest
- php: 7
env:
- EVENT_MANAGER_VERSION="^2.6.2"
- SERVICE_MANAGER_VERSION="^2.7.5"
- php: hhvm
- php: hhvm
- DEPS=locked
- EXECUTE_CS_CHECK=true
- php: 7
env:
- DEPS=latest
- php: 7.1
env:
- DEPS=lowest
- php: 7.1
env:
- EVENT_MANAGER_VERSION="^2.6.2"
- SERVICE_MANAGER_VERSION="^2.7.5"
- DEPS=locked
- php: 7.1
env:
- DEPS=latest
- php: nightly
env:
- DEPS=lowest
- php: nightly
env:
- DEPS=locked
- php: nightly
env:
- DEPS=latest
allow_failures:
- php: hhvm

notifications:
irc: "irc.freenode.org#zftalk.dev"
email: false
- php: nightly

before_install:
- pecl -q install mongodb
- if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
- composer self-update
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then composer require --dev --no-update satooshi/php-coveralls ; fi
- if [[ $EVENT_MANAGER_VERSION != '' ]]; then composer require --no-update "zendframework/zend-eventmanager:$EVENT_MANAGER_VERSION" ; fi
- if [[ $EVENT_MANAGER_VERSION == '' ]]; then composer require --no-update "zendframework/zend-eventmanager:^3.0" ; fi
- if [[ $SERVICE_MANAGER_VERSION != '' ]]; then composer require --dev --no-update "zendframework/zend-servicemanager:$SERVICE_MANAGER_VERSION" ; fi
- if [[ $SERVICE_MANAGER_VERSION == '' ]]; then composer require --dev --no-update "zendframework/zend-servicemanager:^3.0.3" ; fi
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
- travis_retry composer self-update

install:
- travis_retry composer install --no-interaction --ignore-platform-reqs
- travis_retry composer install $COMPOSER_ARGS --ignore-platform-reqs
- if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi
- if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
- if [[ $DEPS == 'lowest' ]]; then travis_retry composer update $COMPOSER_ARGS --prefer-lowest --prefer-stable ; fi
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
- stty cols 120
- COLUMNS=120 composer show

script:
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then ./vendor/bin/phpunit --coverage-clover clover.xml ; fi
- if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then ./vendor/bin/phpunit ; fi
- if [[ $EXECUTE_CS_CHECK == 'true' ]]; then ./vendor/bin/php-cs-fixer fix -v --diff --dry-run ; fi
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; else composer test ; fi
- if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi
- if [[ $DEPLOY_DOCS == "true" && "$TRAVIS_TEST_RESULT" == "0" ]]; then wget -O theme-installer.sh "https://raw.githubusercontent.com/zendframework/zf-mkdoc-theme/master/theme-installer.sh" ; chmod 755 theme-installer.sh ; ./theme-installer.sh ; fi

after_success:
- if [[ $DEPLOY_DOCS == "true" ]]; then echo "Preparing to build and deploy documentation" ; ./zf-mkdoc-theme/deploy.sh ; echo "Completed deploying documentation" ; fi

after_script:
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then ./vendor/bin/coveralls ; fi
- if [[ $TEST_COVERAGE == 'true' ]]; then composer upload-coverage ; fi

notifications:
email: false
slack:
rooms:
- secure: "MlhbWQ2bxDu9dmQ7o2v/WwwAedl57SVVew0XN/Wvbnt1Q8DY+kBGVxmV7DzurOG0iiq7pzYySNgdyqKpE/2g1IhWD7txrT9BCSq0xPk4i+AUn4xMViZKCVkPYhaFo9K3Z1HnPJPfcnDz075umGKWhfip12LSIMkXRqkNANgKLZ3ouDFRRG1NL7bOmW8GDIAcF3TpIDCy9L+awnGMHTtSO6M1jtueksQpBH7ESosrtkferzNVeV2USvzZbzI04PQ9vsrOOZnkqXgNsk3+gMvZNw6PbCk3eOmgGyFaygpL1NXi3VV6sK6SFtwiuwAiEhiFudOnovpE/90HKtWyCISSSGMlUHF6trEVGR0tQxuw+Du1HNrBhiWZHj6vdMpNdZSEqwBEbCeO5LAHM9fKDIT2utQQXrk62julZCvnAupImgBl5IswlO6f/cGv8/cesLulyc9t6L0LCuuXG2xK/WPSCOtkFB4nuOgNNNXhkljyrYxi8poXGa+4SupqCMA0iNPeUB6NnyCMrBCbUnjEjNIGMezx7ELIoepJuw66py6smigYGyrVXhodlGPvr7jaXVjYHNbDadHA55Vk6tRgYwTZclnrSn8sU3jI3xW/a6APkwQMd40yc+GAy5F72jpONiXeB7f8UG+d4qoWH4doBJii+cb/tVroH1tFDlfTSa5XRec="
on_success: change
on_failure: always
18 changes: 16 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ All notable changes to this project will be documented in this file, in reverse

- Nothing.

### Changed

- [#73](https://github.com/zendframework/zend-session/pull/73) modifies the
`SessionManagerFactory` to take into account the `$requestedName`; if the
`$requestedName` is the name of a class that implements `ManagerInterface`,
that class will be instantiated instead of `SessionManager`, but using the
same arguments (`$config, $storage, $savehandler, $validators, $options`).

### Deprecated

- Nothing.
Expand All @@ -20,7 +28,7 @@ All notable changes to this project will be documented in this file, in reverse

- Nothing.

## 2.7.4 - TBD
## 2.7.4 - 2017-06-19

### Added

Expand All @@ -36,7 +44,13 @@ All notable changes to this project will be documented in this file, in reverse

### Fixed

- Nothing.
- [#66](https://github.com/zendframework/zend-session/pull/66) fixes how the
`Cache` save handler's `destroy()` method works, ensuring it does not attempt
to remove an item by `$id` if it does not already exist in the cache.
- [#79](https://github.com/zendframework/zend-session/pull/79) updates the
signature of `AbstractContainer::offsetGet()` to match
`Zend\Stdlib\ArrayObject` and return by reference, fixing an issue when
running under PHP 7.1+.

## 2.7.3 - 2016-07-05

Expand Down
14 changes: 7 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,24 +77,24 @@ To do so:

## Running Coding Standards Checks

This component uses [php-cs-fixer](http://cs.sensiolabs.org/) for coding
This component uses [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) for coding
standards checks, and provides configuration for our selected checks.
`php-cs-fixer` is installed by default via Composer.
`phpcs` is installed by default via Composer.

To run checks only:

```console
$ ./vendor/bin/php-cs-fixer fix . -v --diff --dry-run --config-file=.php_cs
$ composer cs-check
```

To have `php-cs-fixer` attempt to fix problems for you, omit the `--dry-run`
flag:
`phpcs` also includes a tool for fixing most CS violations, `phpcbf`:


```console
$ ./vendor/bin/php-cs-fixer fix . -v --diff --config-file=.php_cs
$ composer cs-fix
```

If you allow php-cs-fixer to fix CS issues, please re-run the tests to ensure
If you allow `phpcbf` to fix CS issues, please re-run the tests to ensure
they pass, and make sure you add and commit the changes after verification.

## Recommended Workflow for Contributions
Expand Down
33 changes: 25 additions & 8 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,28 @@
}
},
"require": {
"php": "^5.5 || ^7.0",
"php": "^7.0 || ^5.6",
"zendframework/zend-eventmanager": "^2.6.2 || ^3.0",
"zendframework/zend-stdlib": "^2.7 || ^3.0"
},
"require-dev": {
"container-interop/container-interop": "^1.1",
"mongodb/mongodb": "^1.0.1",
"phpunit/phpunit": "^6.0.8 || ^5.7.15",
"zendframework/zend-cache": "^2.6.1",
"zendframework/zend-coding-standard": "~1.0.0",
"zendframework/zend-db": "^2.7",
"zendframework/zend-http": "^2.5.4",
"zendframework/zend-servicemanager": "^2.7.5 || ^3.0.3",
"zendframework/zend-validator": "^2.6",
"container-interop/container-interop": "^1.1",
"mongodb/mongodb": "^1.0.1",
"fabpot/php-cs-fixer": "1.7.*",
"phpunit/PHPUnit": "~4.0"
"zendframework/zend-validator": "^2.6"
},
"suggest": {
"mongodb/mongodb": "If you want to use the MongoDB session save handler",
"zendframework/zend-cache": "Zend\\Cache component",
"zendframework/zend-db": "Zend\\Db component",
"zendframework/zend-http": "Zend\\Http component",
"zendframework/zend-servicemanager": "Zend\\ServiceManager component",
"zendframework/zend-validator": "Zend\\Validator component",
"mongodb/mongodb": "If you want to use the MongoDB session save handler"
"zendframework/zend-validator": "Zend\\Validator component"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand All @@ -48,9 +48,26 @@
"config-provider": "Zend\\Session\\ConfigProvider"
}
},
"config": {
"sort-packages": true
},
"autoload-dev": {
"files": [
"test/autoload.php"
],
"psr-4": {
"ZendTest\\Session\\": "test/"
}
},
"scripts": {
"check": [
"@cs-check",
"@test"
],
"cs-check": "phpcs",
"cs-fix": "phpcbf",
"test": "phpunit --colors=always",
"test-coverage": "phpunit --colors=always --coverage-clover clover.xml",
"upload-coverage": "coveralls -v"
}
}
Loading